From 9d0a5d4620a2aa5dc01b150e5ebe7613238cae1c Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Mon, 23 Dec 2024 16:29:28 -0800 Subject: [PATCH] [Telemetry] Add missing virtual destructors (#121015) Fixes warnings after #121003. --- llvm/include/llvm/Telemetry/Telemetry.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/llvm/include/llvm/Telemetry/Telemetry.h b/llvm/include/llvm/Telemetry/Telemetry.h index bbf0ac84d667a..344a49df5cbf0 100644 --- a/llvm/include/llvm/Telemetry/Telemetry.h +++ b/llvm/include/llvm/Telemetry/Telemetry.h @@ -30,6 +30,8 @@ namespace telemetry { class Serializer { public: + virtual ~Serializer() = default; + virtual Error init() = 0; virtual void write(StringRef KeyName, bool Value) = 0; virtual void write(StringRef KeyName, StringRef Value) = 0; @@ -62,6 +64,8 @@ class Serializer { /// This struct can be extended as needed to add additional configuration /// points specific to a vendor's implementation. struct Config { + virtual ~Config() = default; + // If true, telemetry will be enabled. const bool EnableTelemetry; Config(bool E) : EnableTelemetry(E) {} @@ -132,6 +136,8 @@ class Destination { /// monitored and transmitting the data elsewhere. class Manager { public: + virtual ~Manager() = default; + // Optional callback for subclasses to perform additional tasks before // dispatching to Destinations. virtual Error preDispatch(TelemetryInfo *Entry) = 0;