From 0d6d5665a826636f1e5d6fb69270bf2cb0ba9350 Mon Sep 17 00:00:00 2001 From: bradam12 <5084044+bradam12@users.noreply.github.com> Date: Tue, 20 Feb 2024 11:20:35 -0500 Subject: [PATCH 1/2] fix: error if autolink reference not found --- github/repository_utils.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/github/repository_utils.go b/github/repository_utils.go index 1596b97bd7..356c84f8fe 100644 --- a/github/repository_utils.go +++ b/github/repository_utils.go @@ -98,7 +98,7 @@ func getAutolinkByKeyPrefix(client *github.Client, owner, repo, keyPrefix string } } - return nil, nil + return nil, fmt.Errorf("cannot find autolink reference %s in repo %s/%s", keyPrefix, owner, repo) } // listAutolinks returns all autolink references for the given repository. From 24eb62a98e2bd0ec5732f81611fdad8142d7ec2b Mon Sep 17 00:00:00 2001 From: bradam12 <5084044+bradam12@users.noreply.github.com> Date: Tue, 5 Mar 2024 00:06:04 -0500 Subject: [PATCH 2/2] Add test for importing an invalid key --- .../resource_github_repository_autolink_reference_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/github/resource_github_repository_autolink_reference_test.go b/github/resource_github_repository_autolink_reference_test.go index 73a09cb2b5..87c01a2cc4 100644 --- a/github/resource_github_repository_autolink_reference_test.go +++ b/github/resource_github_repository_autolink_reference_test.go @@ -2,6 +2,7 @@ package github import ( "fmt" + "regexp" "testing" "github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest" @@ -288,6 +289,12 @@ func TestAccGithubRepositoryAutolinkReference(t *testing.T) { ImportStateVerify: true, ImportStateId: fmt.Sprintf("oof-%s/OOF-", randomID), }, + { + ResourceName: "github_repository_autolink_reference.autolink", + ImportState: true, + ImportStateId: fmt.Sprintf("oof-%s/OCTOCAT-", randomID), + ExpectError: regexp.MustCompile(`cannot find autolink reference`), + }, }, }) }