Added encrypted_value to Actions + Organizations's secrets

[nadenf]

Fixes:

#704 - Use encrypted_value in github_actions_organization_secret and github_actions_secret

[tibbes]

Thanks for your pull requests @nadenf! I think @jcudit is going to post a fuller review shortly, but I just wanted to leave a quick note on the blocker for merging this.

[nadenf]

@jcudit @tibbes .. All changes made.

[tibbes]

Thanks @nadenf. 👍 on the base64 changes. I've also manually tested that using encrypted_value works (for repo-level secrets).

[tibbes]

But we seem to have lost 6880b90 (the commit that removes data_source_github_repository_branches.go)

[nadenf]

@tibbes .. File has been removed.

[hoxu]

Is there documentation somewhere on how to create the encrypted_value using the public key?

[jcudit]

@hoxu a (hack) workaround would be to:

• configure your _secret resource using a plaintext_value
• TF_LOG=DEBUG terraform apply ... the configuration
• extract the encrypted and base64 encoded string that is sent to the GitHub API
• use the extracted value in the encrypted_value field going forward

example

---[ REQUEST ]---------------------------------------
PUT /orgs/.../actions/secrets/test_plaintext_secret HTTP/1.1
Host: api.github.com
User-Agent: go-github
Content-Length: 176
Accept: application/vnd.github.v3+json
Content-Type: application/json
Accept-Encoding: gzip

{
 "key_id": "568250167242549743",
 "encrypted_value": "zEyV5qMXLrvfBBxJJ8FWOHj64TIcFicNNUnnR0mjpjZh1ExZA7fDjUPM/5NKBlMgm/EFg87n3y6PT2M46B7JECRIPZcykDGbBh8=",
 "visibility": "private"
}

I have not tried this personally but theoretically this should work if I am not overlooking something.

[hoxu]

@jcudit thanks, this indeed works. But if you have remote state (especially with versioning), you need to manually comment out the backend, terraform init, do all this, enable the backend again and terraform init. In my opinion it's too cumbersome. And these steps are not documented on https://registry.terraform.io/providers/integrations/github/latest/docs/resources/actions_secret