Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added resources for Environment + Environment Secrets #805

Merged
merged 8 commits into from
Jun 18, 2021
Merged

Added resources for Environment + Environment Secrets #805

merged 8 commits into from
Jun 18, 2021

Conversation

nadenf
Copy link
Contributor

@nadenf nadenf commented Jun 3, 2021 •
edited
Loading

Fixes:

#528 - [feature request] add deployment environment resource
#681 - github_actions_secret: support environment secrets

@jcudit jcudit added this to the v4.11.0 milestone Jun 3, 2021
@tibbes tibbes mentioned this pull request Jun 4, 2021
Merged
jcudit
jcudit reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reviewed this as a group and come up with a couple of suggestions for next steps but this doesn't look too far off from shipping. The main points we should address are:

  • Adding ConflictsWith
  • Edits to the vendor/ folder

github/resource_github_actions_environment_secret_test.go Outdated Show resolved Hide resolved
vendor/github.com/google/go-github/v35/github/actions_secrets.go Outdated Show resolved Hide resolved
github/resource_github_repository_environment.go Outdated Show resolved Hide resolved
github/resource_github_actions_environment_secret.go Outdated Show resolved Hide resolved
@jcudit jcudit modified the milestones: v4.11.0, v4.12.0 Jun 4, 2021
@nadenf
Copy link
Contributor Author

nadenf commented Jun 5, 2021

@jcudit @tibbes .. All changes made. Hopefully in time for 4.11 ?

jcudit
jcudit approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jcudit
Copy link
Contributor

jcudit commented Jun 15, 2021

Ah, just realized we need to update website.erb as well. Feel free to cherry-pick 4e8e976 and this can go out with the upcoming release.

@nadenf
Copy link
Contributor Author

nadenf commented Jun 15, 2021

@jcudit .. Done !

@jcudit jcudit merged commit 1da31ea into integrations:master Jun 18, 2021
@nadenf nadenf deleted the environment branch June 18, 2021 21:06
@MajorBreakfast MajorBreakfast mentioned this pull request Jun 21, 2021
Closed
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@nadenf
Added resources for Environment + Environment Secrets (integrations#805)
589d0a5 
* Added resources for Environment + Environment Secrets

* Added support for encrypted value

* Added conflicts with, fixed formatting and changes to go-github

* Fixed indentation

* Fixed indentation

* Fixed indentation

* Encrypted value needs to be in Base64 format

* fixup! add new resources to website.erb

Co-authored-by: Jeremy Udit <jcudit@github.com>
@kfcampbell kfcampbell mentioned this pull request Oct 27, 2022
Closed
This was referenced Dec 6, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcudit jcudit jcudit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nadenf @jcudit