Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed : insecure_ssl parameter behaviour in webhook creation #365

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

vikkyomkar
Copy link
Contributor

insecure_ssl parameter is not working while creating webhook for org/repo
This PR fixes this behaviour
#352

@ghost ghost added the size/XS label Feb 27, 2020
@vikkyomkar
Copy link
Contributor Author

@jcudit Can you please review this PR?

Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance tests have passed. Thanks for the fix @vikkyomkar!

@jcudit jcudit merged commit 888d8b8 into integrations:master Feb 27, 2020
@vikkyomkar vikkyomkar deleted the issue-352 branch February 28, 2020 06:17
@jcudit jcudit mentioned this pull request Mar 2, 2020
@ajsit
Copy link

ajsit commented Mar 3, 2020

Any idea when this fix will be rolled out?

kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
Fixed : insecure_ssl parameter behaviour in webhook creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants