Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: GitHub Organization is not required for all datasources #242

Merged
merged 3 commits into from
Jun 27, 2019
Merged

Bug Fix: GitHub Organization is not required for all datasources #242

merged 3 commits into from
Jun 27, 2019

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jun 21, 2019

Addressing part of #230 where GitHub organization is required by Terraform, although not necessary for the datasources.
Before fix:

        errors during apply: PUT https://api.github.com/orgs//memberships/mbang-github2: 404 Not Found []

        To match:

        This resource requires GitHub organization to be set on the provider.


FAIL

After fix:

=== RUN   TestProvider_individual
--- PASS: TestProvider_individual (0.95s)
PASS

@ghost ghost added the size/L label Jun 21, 2019
@megan07 megan07 requested a review from a team June 21, 2019 19:59
@ghost ghost added the Type: Documentation Improvements or additions to documentation label Jun 26, 2019
tracypholmes
tracypholmes approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@tracypholmes tracypholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@megan07 megan07 merged commit 593eeab into master Jun 27, 2019
@megan07 megan07 deleted the f-organization-optional branch June 27, 2019 19:20
@megan07 megan07 mentioned this pull request Jun 27, 2019
Closed
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@megan07
Bug Fix: GitHub Organization is not required for all datasources (int…
ad4c0e9 
…egrations#242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracypholmes tracypholmes tracypholmes approved these changes

Assignees
No one assigned
Labels
size/L Type: Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@megan07 @tracypholmes