Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] support enabling and disabling vulnerability alerts #238

Closed
majormoses opened this issue Jun 7, 2019 · 8 comments · Fixed by #444
Closed

[Feature Request] support enabling and disabling vulnerability alerts #238

majormoses opened this issue Jun 7, 2019 · 8 comments · Fixed by #444
Labels
Type: Feature New feature or request

Comments

@majormoses
Copy link
Contributor

Github (now) supports enabling and disabling Githubs vulnerability alerts settings on the repository.

The upstream golang library has merged support for this as of v25.1.1 and can be pulled in via #228.

It would be really great if we could enable this.

@majormoses majormoses changed the title [Feature Request] support enabling and disabling vulnerability reports [Feature Request] support enabling and disabling vulnerability alerts Jun 7, 2019
@biancarosa
Copy link

biancarosa commented Jun 7, 2019

I'll give it a try on this one. We're currently needing this in our github automation.

@tracypholmes tracypholmes added the Type: Feature New feature or request label Jun 28, 2019
@tracypholmes
Copy link
Contributor

Hi @biancarosa. We would be happy to accept a PR for this if you would like to open one. Looking forward to it, and let us know if you have any questions!

@tiesmaster
Copy link

I don't know if this should really a separate issue, but you can also grant more people access to your security alerts. It'd be nice if you can also do that.

@kszarek
Copy link

kszarek commented Dec 27, 2019

@biancarosa are you going to work on this? I also need it for my Github automation.

@mwarkentin
Copy link
Contributor

We could use this too. :)

@jtsaito
Copy link
Contributor

jtsaito commented Mar 9, 2020

Please see https://github.com/terraform-providers/terraform-provider-github/pull/382 . I hope it's okay I added the PR right away.

@biancarosa If you have meanwhile worked on a solution, I'm happy to drop my PR and go ahead with yours.

@jcudit
Copy link
Contributor

jcudit commented Mar 12, 2020

@jtsaito - thanks for reviving this one.

Regarding the proposed implementation, I am in favour of this being a boolean on the existing repository resource, but will defer to what the majority of users feel about the configuration experience. I think this issue would benefit from another PR that leverages a boolean instead of a new top-level resource.

Lets give @biancarosa until next week to respond as well as some time for the community to chime in on how this implementation should progress.

@jtsaito
Copy link
Contributor

jtsaito commented May 3, 2020

Submitted a PR with vulnerability alerts as an attribute on the repo resource: https://github.com/terraform-providers/terraform-provider-github/pull/444 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants