Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: import github_repository #237

Merged
merged 2 commits into from
Jun 10, 2019
Merged

Bug Fix: import github_repository #237

merged 2 commits into from
Jun 10, 2019

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jun 5, 2019 •
edited
Loading

Addressing #229 where has_projects wasn't being imported
Before fix:

        (map[string]string) (len=1) {
         (string) (len=12) "has_projects": (string) (len=4) "true"
        }

FAIL

After fix:

=== RUN   TestAccGithubRepository_importHasProjects
--- PASS: TestAccGithubRepository_importHasProjects (7.24s)
PASS

@ghost ghost added the size/S label Jun 5, 2019
@megan07 megan07 requested a review from a team June 5, 2019 19:51
katbyte
katbyte approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@megan07 megan07 merged commit 79fac37 into master Jun 10, 2019
@megan07 megan07 mentioned this pull request Jun 10, 2019
Closed
@paultyng paultyng deleted the b-import-github-repo branch September 8, 2020 13:22
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@megan07
Bug Fix: import github_repository (integrations#237)
d975e0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@megan07 @katbyte