Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: github_repository #109

Merged
merged 1 commit into from
Aug 3, 2018
Merged

New Data Source: github_repository #109

merged 1 commit into from
Aug 3, 2018

Conversation

radeksimko
Copy link
Contributor

Acceptance Tests

make testacc TEST=./github TESTARGS='-run=TestAccGithubRepositoryDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./github -v -run=TestAccGithubRepositoryDataSource_ -timeout 120m
=== RUN   TestAccGithubRepositoryDataSource_fullName_noMatchReturnsError
--- PASS: TestAccGithubRepositoryDataSource_fullName_noMatchReturnsError (0.61s)
=== RUN   TestAccGithubRepositoryDataSource_name_noMatchReturnsError
--- PASS: TestAccGithubRepositoryDataSource_name_noMatchReturnsError (0.17s)
=== RUN   TestAccGithubRepositoryDataSource_fullName_existing
--- PASS: TestAccGithubRepositoryDataSource_fullName_existing (0.71s)
=== RUN   TestAccGithubRepositoryDataSource_name_existing
--- PASS: TestAccGithubRepositoryDataSource_name_existing (0.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-github/github	2.373s

tombuildsstuff
tombuildsstuff approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor nits but this otherwise LGTM 👍

github/data_source_github_repository.go Outdated
d.Set("archived", repo.Archived)
d.Set("topics", flattenStringList(repo.Topics))

d.SetId(repoName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor shouldn't this be above the d.Set()'s incase there's a crash?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I'll move it.

github/data_source_github_repository.go Outdated
d.Set("git_clone_url", repo.GitURL)
d.Set("http_clone_url", repo.CloneURL)
d.Set("archived", repo.Archived)
d.Set("topics", flattenStringList(repo.Topics))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is a complex object, can we check for errors here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good idea, I'll add the check.

@radeksimko radeksimko force-pushed the f-new-ds-repository branch from d734621 to afdfd08 Compare August 3, 2018 15:01
@radeksimko
Copy link
Contributor Author

Addressed both comments & Travis green & acceptance tests still passing.

@radeksimko radeksimko merged commit 19a08bb into master Aug 3, 2018
@radeksimko radeksimko deleted the f-new-ds-repository branch August 3, 2018 15:05
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@radeksimko
Merge pull request integrations#109 from terraform-providers/f-new-ds…
ad84402 
…-repository

New Data Source: github_repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
New data source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @tombuildsstuff