Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document release process (and cut 0.4.1) #95

Closed
scottyhq opened this issue Dec 2, 2020 · 18 comments · Fixed by #96
Closed

Document release process (and cut 0.4.1) #95

scottyhq opened this issue Dec 2, 2020 · 18 comments · Fixed by #96

Comments

@scottyhq
Copy link
Collaborator

scottyhq commented Dec 2, 2020

It would be great to get a new release (0.4.1) out. @martindurant - I'd be happy to add a small section in the docs regarding your preferred way to do this.

Or we could add a "publish" github action to push to pypi as we're doing in intake-stac that just requires pushing a new tag. A changelog would also be nice to add.

@martindurant
Copy link
Member

we could add a "publish" github action to push to pypi

Sounds like a good plan! I have still to get around to doing any GHaction myself.

The changelog could be generated from PR titles for now.

@weiji14
Copy link
Collaborator

weiji14 commented Jan 13, 2021

Gentle nudge to see if we could we get a v0.4.1 tag for intake-xarray 🙂

P.S. Happy to help out with repo maintainence if people have too much on their plate!

@scottyhq
Copy link
Collaborator Author

right, thanks @weiji14 i've been a bit busy lately and would be happy if you released a new version! Note that it's probably worth sorting this issue out and adding a test for the many file case #94 (comment)

@weiji14
Copy link
Collaborator

weiji14 commented Jan 14, 2021

Cool, I haven't got permissions on this repo but happy to get added to the team/organization here (and on PyPI?) to see what I can do for the release. The changelog actually said the release was on 2020-12-03, should we update that?

The issue at #94 seems a bit complicated to write a test case for, and I'd suggest solving that in v0.4.2.

@scottyhq
Copy link
Collaborator Author

should we update that?
yep ;)

Seems that I can't change repo permissions settings, @martindurant are you the only one currently with those permissions?

@martindurant
Copy link
Member

I thought you could too @scottyhq , at a maintainer. I don't see a higher level of permissions. In any case, I have invited @weiji14 to that level too.

I'll add you both to pypi - do you both have the same usernames as on github?

@scottyhq
Copy link
Collaborator Author

scottyhq commented Jan 14, 2021

I'll add you both to pypi - do you both have the same usernames as on github?

yes for me

@weiji14
Copy link
Collaborator

weiji14 commented Jan 14, 2021

Yep, I have the same username on PyPI.

@martindurant
Copy link
Member

You are both added as maintainers on pypi

@weiji14
Copy link
Collaborator

weiji14 commented Jan 14, 2021

Great, I'll push a v0.4.1 tag and the PyPI publish workflow at https://github.com/intake/intake-xarray/blob/31cb241f5cc74b01bd5d399b0d8fc695acf4063a/.github/workflows/pypipublish.yaml should work 🤞.

@weiji14
Copy link
Collaborator

weiji14 commented Jan 14, 2021

Hmm, looking at https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#release, I think we need to change this line to use 'published' instead of 'created':

on:
release:
types: [created]

@martindurant
Copy link
Member

Feel free to use twine locally too... I have never bothered to click the "release" button in github anyway

@weiji14
Copy link
Collaborator

weiji14 commented Jan 14, 2021

Haven't used twine before 😂, I'll change the GitHub Actions workflow file and re-publish a new v0.4.1 release. Edit: done at 227c675

@martindurant
Copy link
Member

OK, whatever works for you!

@weiji14
Copy link
Collaborator

weiji14 commented Jan 14, 2021

Ok, v0.4.1 is on PyPI at https://pypi.org/project/intake-xarray/0.4.1/ 😄

@martindurant
Copy link
Member

I'll merge the subsequent conda-forge PR when it comes through.

@weiji14
Copy link
Collaborator

weiji14 commented Jan 14, 2021

Cool, happy to be added as a maintainer on https://github.com/conda-forge/intake-xarray-feedstock too 🙂

@martindurant
Copy link
Member

I think the easiest way is to make a PR adding you to the list of maintainers in the meta file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants