Skip to content

Commit c915733

Browse files
anaPerezGhigliaanaPerezGhiglia
committed
Fix tests
- change to assert_receive since the process may need to wait for the respondent lock to be granted
1 parent fdd4a70 commit c915733

File tree

3 files changed

+49
-49
lines changed

3 files changed

+49
-49
lines changed

‎test/ask/runtime/channel_broker_test.exs

+4-4
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ defmodule Ask.Runtime.ChannelBrokerTest do
441441

442442
defp assert_made_calls(respondents, test_channel) do
443443
Enum.each(respondents, fn %{id: id} ->
444-
assert_received [:setup, ^test_channel, %{id: ^id}, _token]
444+
assert_receive [:setup, ^test_channel, %{id: ^id}, _token]
445445
end)
446446

447447
refute_received [:setup, ^test_channel, _respondent, _token]
@@ -451,7 +451,7 @@ defmodule Ask.Runtime.ChannelBrokerTest do
451451
respondent_ids = Enum.map(respondents, & &1.id)
452452

453453
Stream.repeatedly(fn ->
454-
assert_received [:setup, ^test_channel, %{id: id}, _token]
454+
assert_receive [:setup, ^test_channel, %{id: id}, _token]
455455
assert Enum.member?(respondent_ids, id)
456456
end) |> Enum.take(amount)
457457

@@ -460,7 +460,7 @@ defmodule Ask.Runtime.ChannelBrokerTest do
460460

461461
defp assert_sent_smss(respondents, test_channel) do
462462
Enum.each(respondents, fn %{id: id} ->
463-
assert_received [:ask, ^test_channel, %{id: ^id}, _token, _reply, _channel_id]
463+
assert_receive [:ask, ^test_channel, %{id: ^id}, _token, _reply, _channel_id]
464464
end)
465465

466466
refute_received [:ask, ^test_channel, _respondent, _token, _reply, _channel_id]
@@ -470,7 +470,7 @@ defmodule Ask.Runtime.ChannelBrokerTest do
470470
respondent_ids = Enum.map(respondents, & &1.id)
471471

472472
Stream.repeatedly(fn ->
473-
assert_received [:ask, ^test_channel, %{id: id}, _token, _reply, _channel_id]
473+
assert_receive [:ask, ^test_channel, %{id: id}, _token, _reply, _channel_id]
474474
assert Enum.member?(respondent_ids, id)
475475
end) |> Enum.take(amount)
476476

‎test/ask/runtime/survey_broker_test.exs

+20-20
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,14 @@ defmodule Ask.Runtime.SurveyBrokerTest do
4747
# First poll, activate the respondent
4848
SurveyBroker.handle_info(:poll, nil)
4949

50-
assert_received [
50+
assert_receive [
5151
:setup,
5252
^test_channel,
5353
respondent = %Respondent{sanitized_phone_number: ^phone_number},
5454
token
5555
]
5656

57-
assert_received [
57+
assert_receive [
5858
:ask,
5959
^test_channel,
6060
^respondent,
@@ -74,7 +74,7 @@ defmodule Ask.Runtime.SurveyBrokerTest do
7474
SurveyBroker.handle_info(:poll, nil)
7575
refute_received [:setup, _, _, _, _]
7676

77-
assert_received [
77+
assert_receive [
7878
:ask,
7979
^test_channel,
8080
%Respondent{sanitized_phone_number: ^phone_number},
@@ -117,14 +117,14 @@ defmodule Ask.Runtime.SurveyBrokerTest do
117117
# First poll, activate the respondent
118118
SurveyBroker.handle_info(:poll, nil)
119119

120-
assert_received [
120+
assert_receive [
121121
:setup,
122122
^test_channel,
123123
respondent = %Respondent{sanitized_phone_number: ^phone_number},
124124
token
125125
]
126126

127-
assert_received [
127+
assert_receive [
128128
:ask,
129129
^test_channel,
130130
^respondent,
@@ -148,7 +148,7 @@ defmodule Ask.Runtime.SurveyBrokerTest do
148148
SurveyBroker.handle_info(:poll, nil)
149149
refute_received [:setup, _, _, _, _]
150150

151-
assert_received [
151+
assert_receive [
152152
:ask,
153153
^test_channel,
154154
%Respondent{sanitized_phone_number: ^phone_number},
@@ -267,7 +267,7 @@ defmodule Ask.Runtime.SurveyBrokerTest do
267267
# First poll, activate the respondent
268268
SurveyBroker.handle_info(:poll, nil)
269269

270-
assert_received [
270+
assert_receive [
271271
:setup,
272272
^test_channel,
273273
%Respondent{sanitized_phone_number: ^phone_number, mode: ^sequence_mode},
@@ -283,7 +283,7 @@ defmodule Ask.Runtime.SurveyBrokerTest do
283283
# Second poll, retry the question
284284
SurveyBroker.handle_info(:poll, nil)
285285

286-
assert_received [
286+
assert_receive [
287287
:setup,
288288
^test_channel,
289289
%Respondent{sanitized_phone_number: ^phone_number},
@@ -398,14 +398,14 @@ defmodule Ask.Runtime.SurveyBrokerTest do
398398
# First poll, activate the respondent
399399
SurveyBroker.handle_info(:poll, nil)
400400

401-
assert_received [
401+
assert_receive [
402402
:setup,
403403
^test_channel,
404404
respondent = %Respondent{sanitized_phone_number: ^phone_number},
405405
token
406406
]
407407

408-
assert_received [
408+
assert_receive [
409409
:ask,
410410
^test_channel,
411411
^respondent,
@@ -425,7 +425,7 @@ defmodule Ask.Runtime.SurveyBrokerTest do
425425

426426
refute_received [:setup, _, _, _, _]
427427

428-
assert_received [
428+
assert_receive [
429429
:ask,
430430
^test_channel,
431431
%Respondent{sanitized_phone_number: ^phone_number},
@@ -444,7 +444,7 @@ defmodule Ask.Runtime.SurveyBrokerTest do
444444
SurveyBroker.handle_info(:poll, nil)
445445
refute_received [:setup, _, _, _, _]
446446

447-
assert_received [
447+
assert_receive [
448448
:ask,
449449
^test_channel,
450450
%Respondent{sanitized_phone_number: ^phone_number},
@@ -462,7 +462,7 @@ defmodule Ask.Runtime.SurveyBrokerTest do
462462
# Fourth poll, this time fallback to IVR channel
463463
SurveyBroker.handle_info(:poll, nil)
464464

465-
assert_received [
465+
assert_receive [
466466
:setup,
467467
^test_fallback_channel,
468468
%Respondent{sanitized_phone_number: ^phone_number},
@@ -516,7 +516,7 @@ defmodule Ask.Runtime.SurveyBrokerTest do
516516
# First poll, activate the respondent
517517
SurveyBroker.handle_info(:poll, nil)
518518

519-
assert_received [
519+
assert_receive [
520520
:setup,
521521
^test_channel,
522522
%Respondent{sanitized_phone_number: ^phone_number},
@@ -548,7 +548,7 @@ defmodule Ask.Runtime.SurveyBrokerTest do
548548
# Third poll, this time fallback to SMS channel
549549
SurveyBroker.handle_info(:poll, nil)
550550

551-
assert_received [
551+
assert_receive [
552552
:setup,
553553
^test_channel,
554554
%Respondent{sanitized_phone_number: ^phone_number},
@@ -564,14 +564,14 @@ defmodule Ask.Runtime.SurveyBrokerTest do
564564
# Fourth poll, this time fallback to SMS channel
565565
SurveyBroker.handle_info(:poll, nil)
566566

567-
assert_received [
567+
assert_receive [
568568
:setup,
569569
^test_fallback_channel,
570570
respondent = %Respondent{sanitized_phone_number: ^phone_number},
571571
token
572572
]
573573

574-
assert_received [
574+
assert_receive [
575575
:ask,
576576
^test_fallback_channel,
577577
^respondent,
@@ -1185,7 +1185,7 @@ defmodule Ask.Runtime.SurveyBrokerTest do
11851185
{:ok, _} = SurveyLogger.start_link()
11861186
SurveyBroker.poll()
11871187

1188-
assert_received [
1188+
assert_receive [
11891189
:ask,
11901190
^test_channel,
11911191
%Respondent{sanitized_phone_number: ^phone_number},
@@ -1231,7 +1231,7 @@ defmodule Ask.Runtime.SurveyBrokerTest do
12311231
{:ok, _} = SurveyLogger.start_link()
12321232
SurveyBroker.poll()
12331233

1234-
assert_received [
1234+
assert_receive [
12351235
:ask,
12361236
^test_channel,
12371237
%Respondent{sanitized_phone_number: ^phone_number},
@@ -1282,7 +1282,7 @@ defmodule Ask.Runtime.SurveyBrokerTest do
12821282
{:ok, _} = SurveyLogger.start_link()
12831283
SurveyBroker.poll()
12841284

1285-
assert_received [
1285+
assert_receive [
12861286
:ask,
12871287
^test_channel,
12881288
%Respondent{sanitized_phone_number: ^phone_number},

0 commit comments

Comments
 (0)