Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 0.3.8.rc #161

Closed
bleonard opened this issue Jul 5, 2017 · 5 comments
Closed

Test 0.3.8.rc #161

bleonard opened this issue Jul 5, 2017 · 5 comments

Comments

@bleonard
Copy link
Contributor

bleonard commented Jul 5, 2017

@jeremy @vt-gpatrick
I've merged your PRs.
#157
#159
#160

Can you please test out a release candidate?

# Gemfile
gem 'makara', git: 'https://github.com/taskrabbit/makara.git', tag: 'v0.3.8.rc2'
@bleonard
Copy link
Contributor Author

bleonard commented Jul 5, 2017

oh wait. @jeremy has a few more. I'll review those now.

@bleonard bleonard closed this as completed Jul 5, 2017
@bleonard bleonard reopened this Jul 6, 2017
@bleonard
Copy link
Contributor Author

bleonard commented Jul 6, 2017

@jeremy @vt-gpatrick
I've merged your PRs.
#150
#157
#158
#159
#160

Can you please test out a release candidate?

# Gemfile
gem 'makara', git: 'https://github.com/taskrabbit/makara.git', tag: 'v0.3.8.rc3'

@jeremy
Copy link
Contributor

jeremy commented Jul 7, 2017

Tests green. Behaved well in limited rollout. Now in production on Basecamp 3. ✅

@bleonard
Copy link
Contributor Author

bleonard commented Jul 7, 2017

Great! 🎉
Green here too. Waiting to test in prod until I'm back from vacation (next week).

@bleonard
Copy link
Contributor Author

Tested and worked! Pushed new gem to rubygems.
https://rubygems.org/gems/makara

@jeremy @vt-gpatrick you can use that now it you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants