Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Change in emmeans package causes an error in tern.gee #67

Closed
2 tasks done
rvlenth opened this issue Aug 19, 2024 · 2 comments · Fixed by #70
Closed
2 tasks done

[Bug]: Change in emmeans package causes an error in tern.gee #67

rvlenth opened this issue Aug 19, 2024 · 2 comments · Fixed by #70
Labels
bug Something isn't working

Comments

@rvlenth
Copy link
Contributor

rvlenth commented Aug 19, 2024

What happened?

The emmeans package supports both glmgee and geeglm objects, but it was inconsistent in that the latter used infinite d.f. while the former used finite d.f. I have a new update to emmeans that makes them consistent with one another and both now use the finite d.f. (See emmeans issue 496.)This changes some column names in the summaries -- specifically, the confidence limits are now named lower.CL and upper.CL instead of asymp.LCL and asymp.UCL, as is expected in the third line in the code for lsmeans.tern_gee_logistic().

Because the d.f. change was a bug fix in emmeans, I don't want to revert the change, so I am requesting that you change gee.tern so it is compatible.

Additional comment

You have an lsmeans() function that has the same name -- but is incompatible with -- a function of the same name in emmeans. This will confuse your users because they will get different results depending on which package is earlier in the search path:

> tern.gee::lsmeans(fev_fit, data = fev_data)
Error in `[.data.frame`(data.frame(stats::confint(prop_emm)), , c(object$vars$arm,  : 
  undefined columns selected
> # This is the current error message due to the issue reported here

> emmeans::lsmeans(fev_fit, data = fev_data)
Error in emmfcn(...) : argument "specs" is missing, with no default
> # Due to incompatibility between the two functions

Which version(s) of R were you using?

No response

Relevant log output

(No additional material needed)

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.
@rvlenth rvlenth added the bug Something isn't working label Aug 19, 2024
rvlenth added a commit to rvlenth/tern.gee that referenced this issue Aug 19, 2024
@shajoezhu shajoezhu mentioned this issue Aug 21, 2024
@rvlenth
Copy link
Contributor Author

rvlenth commented Aug 21, 2024

OK, 1.10.4 is now on CRAN

@rvlenth rvlenth closed this as completed Aug 21, 2024
@shajoezhu
Copy link
Contributor

Thanks so much @rvlenth , I will prep for a CRAN release

shajoezhu added a commit that referenced this issue Aug 21, 2024
close #66 
close #67

---------

Co-authored-by: Russell V. Lenth <russell-lenth@uiowa.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants