You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After careful observation, it appears that the scda package is not essential for teal.transform. Consequently, it is advantageous for us to separate scda from teal.transform.
Files affected:
When examining the unit test, I noticed that adsl and adtte are used repeatedly. It might be beneficial to generate a concise example dataset specifically for this package.
Acceptance Criteria
Use iris, mtcars, or create a minimal example data that resides only within the package for unit tests and roxygen examples.
This minimal example data will be stored as .rda files in the /data folder.
Revise the roxygen examples to use the minimal example data.
If applicable, update the unit tests to utilize the new data.
If applicable, update affected vignettes.
Update DESCRIPTION file to remove scda and related packages.
Update staged_dependencies.yml
The text was updated successfully, but these errors were encountered:
A follow-up after #139 that closed#133
After I had a chance to do a scda decoupling for goshawk
insightsengineering/goshawk#198 and had a chance
to review scda decoupling for teal.modules.general
insightsengineering/teal.modules.general#534
I realized some changes need to be applied in PRs that were already
merged in other packages.
Main changes:
- I prepend dataset names with package names as now we are having the
same data in multiple packages (`teal.transform::rADAE` and
`teal.modules.general::rADAE` for example)
- added a `data-raw/data.R` file to show how the `data/` folder was
created
- extended `.RBuildignore` file to omit `data-raw/data.R` while building
the package
Related to insightsengineering/nestdevs-tasks#1
Summary
After careful observation, it appears that the scda package is not essential for teal.transform. Consequently, it is advantageous for us to separate scda from teal.transform.
Files affected:
When examining the unit test, I noticed that adsl and adtte are used repeatedly. It might be beneficial to generate a concise example dataset specifically for this package.
Acceptance Criteria
This minimal example data will be stored as .rda files in the /data folder.
scda
and related packages.The text was updated successfully, but these errors were encountered: