Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join_keys added based on keys #58

Open
3 tasks done
mhallal1 opened this issue Jun 30, 2022 · 0 comments
Open
3 tasks done

join_keys added based on keys #58

mhallal1 opened this issue Jun 30, 2022 · 0 comments
Labels
core enhancement New feature or request

Comments

@mhallal1
Copy link
Contributor

Feature description

In the example below, the first FilteredData object will not have joins_keys while the second will:

#won't have join_keys
ds <- init_filtered_data(list(
  ADSL = list(
    dataset = data.frame(USUBJID = "USUBJID", STUDYID = "STUDYID"), 
    keys = c("USUBJID", "STUDYID")
    )
  ))
ds$get_join_keys()

# will have join_keys

ds2 <- init_filtered_data(list(
  ADSL = list(
    dataset = data.frame(USUBJID = "USUBJID", STUDYID = "STUDYID"), 
    keys = c("USUBJID", "STUDYID")
  )),
  join_keys = teal.data::join_keys(
    teal.data::join_key("ADSL", "ADSL", c("USUBJID", "STUDYID"))
  )
)
ds2$get_join_keys()

A suggestion would be to add by default the keys as join_keys for the dataset.
This would make it easier to extract the primary keys of a dataset in data_extrac_srv.

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants