-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove access to data from UI modules #132
Labels
Comments
gogonzo
changed the title
Remove accesss to data from UI modules
Remove access to data from UI modules
Nov 24, 2022
18 tasks
I suggest to not address this issue at this moment (february 2023). PR I've made #185 shows how complex these modules are. Removing UI from the classes is confusing and not relevant at this moment of the refactor process. Issue is related more with the teal 1.0 milestone |
This was referenced Aug 15, 2023
Closed
Closed
Closing this up as it can be done under this issue insightsengineering/teal#669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reason of this issue is that filter-panel UI can't be initialized without data. It's because
filter_panel_ui
is a part ofFIlteredData
class. We would like to initialize empty filter-panel and update it when the data is available.Proposition
UI modules have access to data to initialize the inputs which messes up teal reactivity. Please do:
FIlteredData$new()
should initialize emptyFilteredData
with emptyui/srv_filter_panel
FilteredData$set_filtered_dataset
should createFilteredDataset
and insert it intoprivate$filtered_datasets
(reactiveValues).filtered_datasets
will be then reactive on a change inreactiveValues
This issue will require other actions which should be addressed in the same PR:
The text was updated successfully, but these errors were encountered: