Inconsistent Card Titles

[donyunardi]

From https://github.com/insightsengineering/coredev-tasks/issues/387 by @BLAZEWIM

Steps to reproduce:

1. Launch "patient-profile" from teal.gallery
2. Click the "Lab values" module
3. Add Reporter Card by clicking the plus sign and clicked "Add Card" when the modal appears
4. Click the "Prior medication" module
5. Add Reporter Card by clicking the plus sign and clicked "Add Card" when the modal appears
6. Click the "Reporter previewer" module

Should the card title format be more consistent, i.e. <appname> <module name> Table ?

[donyunardi]

Linking with this comment:
#94 (comment)

The solution is to pass label from tm_g_XXX to srv_g_xxx of all modules using reporter to accomplish this task.

label is already part of srv argument:
https://github.com/insightsengineering/teal.modules.clinical/blob/main/R/tm_t_pp_laboratory.R#L288-L301

[kartikeyakirar]

Should the card title format be more consistent, i.e. Table ?

Maintaining tittle <appname> <module name> Table/Plot can result in repetitive terms, such as "plot plot," as illustrated in the case of the "Bivariate Plots" module 'tm_g_bivariate', leading to redundant titles.

e.g
Exploratory Bivariate Plots Plot

option1 : Consistently retain only the <appname> <module name> while eliminating the trailing plot/table terms.
option2: Develop logic to detect whether the module yields a plot or table and then verify if the same term is already present in the title as a trailing term.

@donyunardi Let me know your thoughts on this?

[kartikeyakirar]

Also I don't think we should include <appname> it will unnecessary clutter the title.

[donyunardi]

Now that we've completed insightsengineering/teal.modules.clinical#835, I feel that we don't need this anymore.

Users now have the freedom to either consistently name the card or utilize the default title/label provided by the module. Any updates to the default values should be discussed at the module level.

I believe we can consider this matter closed.
Thoughts?

[kartikeyakirar]

Agreed. closing this.