Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change modules to use data argument instead of datasets #247

Closed
Tracked by #2
gogonzo opened this issue Jun 2, 2022 · 2 comments · Fixed by #278
Closed
Tracked by #2

Change modules to use data argument instead of datasets #247

gogonzo opened this issue Jun 2, 2022 · 2 comments · Fixed by #278
Assignees
Labels

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Jun 2, 2022

Followup to:

Required fixes:

  • Remove datasets argument and introduce data argument.
  • Use new data_extract and data_merge

NOTE: teal.modules.hermes using datasets$get_data(filtered = TRUE) and datasets$get_data(filtered = FALSE). We need to resolve this situation.

@gogonzo gogonzo transferred this issue from insightsengineering/teal.goshawk Jun 2, 2022
@gogonzo gogonzo added the core label Jun 2, 2022
@danielinteractive
Copy link
Collaborator

@gogonzo does this need to be fixed for this release? or later?

@gogonzo
Copy link
Contributor Author

gogonzo commented Jun 7, 2022

@danielinteractive not this sprint - next increment. Currently it's in sprint 59. We will decide during PI planning if we are able to address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants