From 6541869db71d89f6bdc1fd67a35e59f3f8f4c1fe Mon Sep 17 00:00:00 2001 From: Emily de la Rua Date: Fri, 16 Sep 2022 10:24:21 -0400 Subject: [PATCH 1/3] Update col name --- NEWS.md | 1 + R/tm_a_mmrm.R | 1 + 2 files changed, 2 insertions(+) diff --git a/NEWS.md b/NEWS.md index c37bdb95db..c6bf6bcbed 100644 --- a/NEWS.md +++ b/NEWS.md @@ -8,6 +8,7 @@ * Enhanced the `tm_t_pp_medical_history` module to use the `table_with_settings` module and return the `rtables` object. * Implemented `nestcolor` in examples, refactored `tm_g_barchart_simple` to allow use of `nestcolor`. * Added more descriptive title/labels to `tm_g_ci`. +* Updated `tm_a_mmrm` column name when no treatment is selected from "all obs" to "All Patients". ### Bug fixes diff --git a/R/tm_a_mmrm.R b/R/tm_a_mmrm.R index cf88fba4d0..27c7ba720e 100644 --- a/R/tm_a_mmrm.R +++ b/R/tm_a_mmrm.R @@ -241,6 +241,7 @@ template_mmrm_tables <- function(parentname, layout_list, substitute( expr = + rtables::add_overall_col("All Patients") %>% rtables::split_rows_by(visit_var) %>% tern.mmrm::summarize_lsmeans(arms = FALSE) %>% rtables::append_topleft(paste0(" ", paramcd)), From ed3b49987d5e2a8c85d13c7f130447b8744cb131 Mon Sep 17 00:00:00 2001 From: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 16 Sep 2022 14:27:34 +0000 Subject: [PATCH 2/3] [skip actions] Restyle files --- R/tm_a_mmrm.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/tm_a_mmrm.R b/R/tm_a_mmrm.R index 27c7ba720e..17749dc369 100644 --- a/R/tm_a_mmrm.R +++ b/R/tm_a_mmrm.R @@ -242,7 +242,7 @@ template_mmrm_tables <- function(parentname, substitute( expr = rtables::add_overall_col("All Patients") %>% - rtables::split_rows_by(visit_var) %>% + rtables::split_rows_by(visit_var) %>% tern.mmrm::summarize_lsmeans(arms = FALSE) %>% rtables::append_topleft(paste0(" ", paramcd)), env = list( From 56a68b3b0abe72123681a0e52039aa462ede670c Mon Sep 17 00:00:00 2001 From: Emily de la Rua Date: Fri, 16 Sep 2022 10:59:10 -0400 Subject: [PATCH 3/3] Update tests --- tests/testthat/test-tm_a_mmrm.R | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/testthat/test-tm_a_mmrm.R b/tests/testthat/test-tm_a_mmrm.R index 8d5c986ae7..df0051971f 100644 --- a/tests/testthat/test-tm_a_mmrm.R +++ b/tests/testthat/test-tm_a_mmrm.R @@ -138,6 +138,7 @@ testthat::test_that("template_mmrm_tables works as expected when arm is not cons expected <- list( layout = quote( lyt <- rtables::basic_table() %>% + rtables::add_overall_col("All Patients") %>% rtables::split_rows_by("AVISIT") %>% tern.mmrm::summarize_lsmeans( arms = FALSE