Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DESCRIPTION tern to 0.9.6 #1227

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Update DESCRIPTION tern to 0.9.6 #1227

merged 1 commit into from
Sep 26, 2024

Conversation

shajoezhu
Copy link
Contributor

Pull Request

Fixes #nnn

Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
@shajoezhu shajoezhu changed the title Update DESCRIPTION Update DESCRIPTION tern to 0.9.6 Sep 24, 2024
@shajoezhu shajoezhu added the sme label Sep 24, 2024
@shajoezhu shajoezhu enabled auto-merge (squash) September 24, 2024 05:47
Copy link
Contributor

github-actions bot commented Sep 24, 2024

Unit Tests Summary

    1 files     70 suites   1h 4m 56s ⏱️
  724 tests   614 ✅ 110 💤 0 ❌
1 992 runs  1 767 ✅ 225 💤 0 ❌

Results for commit 55c13ad.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_g_barchart_simple 💔 $217.93$ $+3.54$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💔 $99.25$ $+1.61$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $164.12$ $+4.20$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $250.30$ $+2.11$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💔 $82.24$ $+1.23$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $219.75$ $+2.51$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💚 $78.24$ $-1.01$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💚 $63.75$ $-1.95$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events 💔 $55.10$ $+2.13$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_medical_history 💚 $62.76$ $-1.24$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💚 $75.61$ $-3.45$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💚 $55.45$ $-1.93$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary 💚 $38.01$ $-1.26$ $0$ $0$ $0$ $0$

Results for commit 7ea819e

♻️ This comment has been updated with latest results.

@edelarua
Copy link
Contributor

Do we also want to update the rtables version to >= 0.6.10?

@shajoezhu
Copy link
Contributor Author

Do we also want to update the rtables version to >= 0.6.10?

hi @edelarua , thanks for raising this. I had thought about this, but decided not to. tern 0.9.6 actually had a few fixes that were compatible with earlier rtables and formatters, so I didn't bump the rtables and formatters version in tern, so I don't think we must do here

@edelarua
Copy link
Contributor

Ok perfect! Just wanted to double check.

Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@shajoezhu shajoezhu merged commit cd777c6 into main Sep 26, 2024
29 checks passed
@shajoezhu shajoezhu deleted the shajoezhu-patch-1 branch September 26, 2024 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants