Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in tm_g_km module #891

Closed
chlebowa opened this issue Nov 23, 2023 · 3 comments
Closed

bug in tm_g_km module #891

chlebowa opened this issue Nov 23, 2023 · 3 comments
Assignees
Labels
bug Something isn't working core

Comments

@chlebowa
Copy link
Contributor

Running the example app yields this error:

Warning: Error in : INTEGER() can only be applied to a 'integer', not a 'double' 
 when evaluating qenv code:
plot_list <- lapply(anl, g_km_counter)

May be system-specific as some users could not reproduce.
Happened on:

> R.version
               _                                          
platform       x86_64-pc-linux-gnu                        
arch           x86_64                                     
os             linux-gnu                                  
system         x86_64, linux-gnu                          
status         Patched                                    
major          4                                          
minor          2.2                                        
year           2022                                       
month          11                                         
day            10                                         
svn rev        83330                                      
language       R                                          
version.string R version 4.2.2 Patched (2022-11-10 r83330)
nickname       Innocent and Trusting  

and on

               _                                
platform       x86_64-w64-mingw32               
arch           x86_64                           
os             mingw32                          
crt            ucrt                             
system         x86_64, mingw32                  
status                                          
major          4                                
minor          3.0                              
year           2023                             
month          04                               
day            21                               
svn rev        84292                            
language       R                                
version.string R version 4.3.0 (2023-04-21 ucrt)
nickname       Already Tomorrow   
@chlebowa chlebowa added bug Something isn't working core labels Nov 23, 2023
@averissimo
Copy link
Contributor

averissimo commented Nov 24, 2023

Works fine on: 4.3.2, 4.3.1, 4.2.0

expand for complete `R.version`
               _                           
platform       x86_64-pc-linux-gnu         
arch           x86_64                      
os             linux-gnu                   
system         x86_64, linux-gnu           
status                                     
major          4                           
minor          3.2                         
year           2023                        
month          10                          
day            31                          
svn rev        85441                       
language       R                           
version.string R version 4.3.2 (2023-10-31)
nickname       Eye Holes                   
               _                           
platform       x86_64-pc-linux-gnu         
arch           x86_64                      
os             linux-gnu                   
system         x86_64, linux-gnu           
status                                     
major          4                           
minor          3.1                         
year           2023                        
month          06                          
day            16                          
svn rev        84548                       
language       R                           
version.string R version 4.3.1 (2023-06-16)
nickname       Beagle Scouts               
               _                           
platform       x86_64-pc-linux-gnu         
arch           x86_64                      
os             linux-gnu                   
system         x86_64, linux-gnu           
status                                     
major          4                           
minor          2.0                         
year           2022                        
month          04                          
day            22                          
svn rev        82229                       
language       R                           
version.string R version 4.2.0 (2022-04-22)
nickname       Vigorous Calisthenics       

The problem appears to happens inside g_km_counter which is wrapper around tern::g_km call (I'm using tern@0.9.2.9016 or tern@0.9.2.9017)

@chlebowa
Copy link
Contributor Author

I was on tern 0.8.5.9007. After updating to 0.9.2.9017 everything runs fine.

@m7pr
Copy link
Contributor

m7pr commented Nov 30, 2023

Guys, as @chlebowa noticed, I think you need to update DESCRIPTION https://github.com/insightsengineering/teal.modules.clinical/blob/main/DESCRIPTION#L30 so that teal is newer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core
Projects
None yet
Development

No branches or pull requests

3 participants