Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Why are filters for all datasets shown in patient profile modules #817

Closed
3 tasks done
anajens opened this issue Aug 9, 2023 · 7 comments
Closed
3 tasks done
Labels
bug Something isn't working core question Further information is requested

Comments

@anajens
Copy link
Contributor

anajens commented Aug 9, 2023

What is your question?

Filters for all datasets shown in patient profile modules. For example, tm_t_pp_basic_info only displays variables from ADSL but the filter panel allows the user to filter across all datasets loaded in the app which is a bit confusing. Is there a reason why this is done?
Screen Shot 2023-08-09 at 4 48 18 PM

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@gogonzo
Copy link
Contributor

gogonzo commented Aug 16, 2023

Closing discussion in favor of specific issue

#821

@gogonzo gogonzo closed this as completed Aug 16, 2023
@m7pr
Copy link
Contributor

m7pr commented Sep 20, 2023

This should be solved thanks to @averissimo and his work at #828
@anajens would you be able to double check now?

@anajens
Copy link
Contributor Author

anajens commented Sep 20, 2023

@m7pr @averissimo changes look great! I tested them locally since teal.gallery sample app still shows the old version. Shouldn't it update automatically?

@m7pr
Copy link
Contributor

m7pr commented Sep 20, 2023

@donyunardi what's the procedure for teal.gallery updates?

@donyunardi
Copy link
Contributor

donyunardi commented Sep 20, 2023

It's updated automatically every night:
https://github.com/insightsengineering/teal.gallery/blob/d911854bc7d0667ab08a9be93d17f9acbb8e4065/.github/workflows/deploy.yaml#L2-L12

For awareness, we're planning to update the teal.gallery workflow and pages and the PR hasn't been merged
insightsengineering/teal.gallery#41 (comment)

I just triggered the workflow manually from the PR's branch:
https://github.com/insightsengineering/teal.gallery/actions/runs/6251644702

When this is done, please check the '_dev' version of this app, which is:
https://genentech.shinyapps.io/nest_patient-profile_dev/

The app should take the latest main from tmc.

@donyunardi
Copy link
Contributor

I made a small update to my previous statement.

@m7pr
Copy link
Contributor

m7pr commented Sep 21, 2023

Thanks for the thorough reply @donyunardi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants