Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UAT] Fix footer in table #633

Closed
BLAZEWIM opened this issue Oct 5, 2022 · 2 comments · Fixed by #646
Closed

[UAT] Fix footer in table #633

BLAZEWIM opened this issue Oct 5, 2022 · 2 comments · Fixed by #646
Assignees
Labels
bug Something isn't working good first issue Good for newcomers sme

Comments

@BLAZEWIM
Copy link
Contributor

BLAZEWIM commented Oct 5, 2022

While:

# example(tm_t_abnormality, package = 'teal.modules.clinical')
# shinyApp(app$ui, app$server)

This footer sounds strange:

lyt <- rtables::basic_table(title = "Laboratory Abnormality summary by Category for Lab Test, Parameter", main_footer = "by variables without observed abnormalities are excluded.")

image

Shouldnt it be: Variables without observed abnormalities are excluded. ?

@nikolas-burkoff
Copy link
Contributor

@shajoezhu

@shajoezhu
Copy link
Contributor

Hi @nikolas-burkoff and @BLAZEWIM , thanks for raising this. It was introduced a while back in #282. We will fix it with

"Variables without observed abnormalities are excluded". Thanks!

@shajoezhu shajoezhu added the bug Something isn't working label Oct 11, 2022
@shajoezhu shajoezhu changed the title Fix footer in table [UAT] Fix footer in table Oct 11, 2022
@edelarua edelarua self-assigned this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers sme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants