lint error: logical operator to use && instead of &

[donyunardi]

I'm not sure what to do about the commented code. Both lines look okay to me. And for scalar logical operator, isn't in R we can do logical operator using & and &&? Are we enforcing the usage of &&?

No. For bit operations and vector operation we could use &, but for logical operation we should use &&

Originally posted by @arkadiuszbeer in #602 (comment)

[donyunardi]

We have couple places to update in the package:

However, I saw this sentence when I read the logical operator documentation (?Logic):

Using vectors of more than one element in && or || will give a warning (as from R 4.2.0), or an error if the environment variable _R_CHECK_LENGTH_1_LOGIC2_ is set to a true value (this is intended to become the default in future).

@arkadiuszbeer is it still okay to move forward with the update as lint suggested?

[shajoezhu]

I think this issue will require some careful investigation

[arkadiuszbeer]

Hi @donyunardi,
What is the current status of this issue?
Have you applied the lint suggestions?
Could we close this issue?

[donyunardi]

Hi @arkadiuszbeer
I checked on this and the team did make the changes as suggested.
@shajoezhu if you don't see anything failing, I think we can close this issue.

[shajoezhu]

Sounds good! Thanks @donyunardi and @arkadiuszbeer