Review teal.reporter in tmc (10)

[shajoezhu]

Motivation

This issue is meant to review and comment on the follow tmc reporter.

Todo

• tm_a_mmrm.R
• tm_g_barchart_simple.R
• tm_g_ci.R
• tm_g_forest_tte.R
• tm_g_km.R
• tm_g_lineplot.R

Please see #551 for example

[edelarua]

General teal.reporter notes:

• EDIT: No issues with interface.

[edelarua]

tm_a_mmrm

• Typo on card subtitle: "Mixed Models procedure analyzes results from repeated measures designsin which the outcome is continuous and measured at fixed time points"
• Fields not indicated on cards:
  • Analysis Variable
  • Covariates (except for in the Fixed effects table)
  • Subject Identifier
  • Weights for LS means
  • Correlation Structure
  • Optimization Algorithm
  • Show Relative Change (LS means table)

[edelarua]

tm_g_barchart_simple

• Looks great - all info is included in the plot

[edelarua]

tm_g_ci

• Fields not indicated on cards:
  • Treatment (x axis) - resolved by 564 Add more descriptive title/labels to tm_g_ci #567
  • Analyzed Value (y axis) - lab value - resolved by 564 Add more descriptive title/labels to tm_g_ci #567
  • Visit

[edelarua]

tm_g_forest_tte

• Field not indicated on cards:
  • Stratify by

[edelarua]

tm_g_km

• Fields not indicated on cards:
  • p-value method for Coxph (Hazard Ratio)
  • Ties for Coxph (Hazard Ratio)

[edelarua]

tm_g_lineplot

• Good - all info is included in the plot

[edelarua]

Unrelated to teal.reporter - notes for SME team:

• tm_a_mmrm: When "Show Relative Change" is set to none, the first column header disappears from the table.
• tm_g_ci: "Treatment Group" text in plot title and x-axis label should be changed to the actual selected treatment variable name.
• tm_g_forest_tte: When table is too wide, information is cut-off and not visible.

@shajoezhu just a few things I noticed while going through the functions for teal.reporter. Let me know if I should create issues for any of these.

[shajoezhu]

Unrelated to teal.reporter - notes for SME team:

• tm_a_mmrm: When "Show Relative Change" is set to none, the first column header disappears from the table.
• tm_g_ci: "Treatment Group" text in plot title and x-axis label should be changed to the actual selected treatment variable name.
• tm_g_forest_tte: When table is too wide, information is cut-off and not visible.

@shajoezhu just a few things I noticed while going through the functions for teal.reporter. Let me know if I should create issues for any of these.

Thanks so much @edelarua! yes, please spin up some issues on these three items.

We will revisit teal.reporter iteam as a whole, and catch-up with the core-dev team. Thanks!

[Melkiades]

General teal.reporter notes:

• "Show R Code" is listed twice with the first one blank (possibly just for me?)
• Filtering by a continuous variable returns undescriptive info in Filter State section. I would suggest adding text to indicate that the first value is the minimum in the filtered range and the second is the maximum. i.e. When filtering AGE to include range 10-20, cards return:

AGE:
    selected:
    - 10.0
    - 20.0
    keep_na: no
    keep_inf: no

I tried to look specifically for these two problems and in my case it was understandable and no duplication of show r code was present:

Filters for dataset: ADSL
  Filtering on: COUNTRY
    Selected values: CHN USA BRA PAK RUS JPN GBR CAN
    Include missing values: FALSE
Filters for dataset: ADCM
  Filtering on: ADURN
    Selected range:   0.000 - 171.000
    Include missing values: FALSE
  Filtering on: ASTDTM
    Selected range: 2019-03-17 01:00:00 - 2020-02-13 01:00:00
    Include missing values: FALSE

[edelarua]

General teal.reporter notes:

• "Show R Code" is listed twice with the first one blank (possibly just for me?)
• Filtering by a continuous variable returns undescriptive info in Filter State section. I would suggest adding text to indicate that the first value is the minimum in the filtered range and the second is the maximum. i.e. When filtering AGE to include range 10-20, cards return:

AGE:
    selected:
    - 10.0
    - 20.0
    keep_na: no
    keep_inf: no

I tried to look specifically for these two problems and in my case it was understandable and no duplication of show r code was present:

Filters for dataset: ADSL
  Filtering on: COUNTRY
    Selected values: CHN USA BRA PAK RUS JPN GBR CAN
    Include missing values: FALSE
Filters for dataset: ADCM
  Filtering on: ADURN
    Selected range:   0.000 - 171.000
    Include missing values: FALSE
  Filtering on: ASTDTM
    Selected range: 2019-03-17 01:00:00 - 2020-02-13 01:00:00
    Include missing values: FALSE

In that case I am probably using an outdated version of some necessary package. I updated my packages beforehand so I'm not sure why the issue occurred but I'll try to update again and hopefully that fixes it.

EDIT: All looks good now. Thanks :)