Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review teal.reporter in tmc (7) #557

Closed
6 tasks done
shajoezhu opened this issue Aug 16, 2022 · 1 comment
Closed
6 tasks done

Review teal.reporter in tmc (7) #557

shajoezhu opened this issue Aug 16, 2022 · 1 comment
Assignees
Labels

Comments

@shajoezhu
Copy link
Contributor

shajoezhu commented Aug 16, 2022

Motivation

This issue is meant to review and comment on the follow tmc reporter.

Todo

  • tm_t_mult_events.R
  • tm_t_pp_basic_info.R
  • tm_t_pp_laboratory.R
  • tm_t_pp_medical_history.R
  • tm_t_pp_prior_medication.R
  • tm_t_shift_by_arm.R

Please see #551 for example

@shajoezhu shajoezhu added the sme label Aug 16, 2022
@Melkiades Melkiades self-assigned this Aug 18, 2022
@Melkiades
Copy link
Contributor

Melkiades commented Aug 18, 2022

General notes: anything I select on the left panel is only evident from the table output, there is nothing highlighting my selection from there. About filtering, I have just a note about adding time ranges, it seems that if you modify them in the filtering section directly by typing the plot is not updated, while it is by using the pop-up.

tm_t_mult_events is fine.
tm_t_pp_basic_info is fine.
tm_t_pp_laboratory is also fine.
tm_t_pp_medical_history is fine.
tm_t_pp_prior_medication is quite fine.
tm_t_shift_by_arm is also fine.

I confirm that even when on the left column there are FILTERS they do not appear in the card if not in the output and raw code. Should I spawn 2 issues @shajoezhu?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants