Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review teal.reporter in tmc (3) #553

Closed
1 task done
shajoezhu opened this issue Aug 16, 2022 · 4 comments
Closed
1 task done

Review teal.reporter in tmc (3) #553

shajoezhu opened this issue Aug 16, 2022 · 4 comments
Assignees
Labels
good first issue Good for newcomers sme

Comments

@shajoezhu
Copy link
Contributor

shajoezhu commented Aug 16, 2022

Motivation

This issue is meant to review and comment on the follow tmc reporter.

Todo

Please see #551 for example

@shajoezhu shajoezhu added sme good first issue Good for newcomers labels Aug 16, 2022
@dingh14 dingh14 self-assigned this Aug 24, 2022
@dingh14
Copy link

dingh14 commented Aug 24, 2022

'Stratify by' does something to the calculations (the numbers and plot change) but the factors are not showing up in the table.

Width of the Plot is capped too small in the Report, making it impossible to see the entire thing. There's an option to expand it on the Forest Response page to make it legible but changing the size there doesn't impact the Report, and there's no option in the Report to expand the plot.

@shajoezhu
Copy link
Contributor Author

hi @dingh14, thanks for this. I was wondering could you provide a screenshot for this? This is going to help us greatly when we gather information, so we won't have to run modules by modules again when summarising. Many thanks!

@dingh14
Copy link

dingh14 commented Aug 30, 2022

image

@shajoezhu There's extra space to the right which expands if I collapse the filter panels, instead of the plot itself expanding. The Forest Response page has this expand button (red circle below) , which fixes the problem in that viewer but only applies to the viewer, but that doesn't exist in the Report previewer or the report itself:

image

@shajoezhu
Copy link
Contributor Author

Fantastic! Thanks so much @dingh14 ! I am going to close this issue for now. And we will track the changes and plan in a separate thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers sme
Projects
None yet
Development

No branches or pull requests

2 participants