Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(tm_a_mmrm) Name of the column could be improved #11

Closed
cicdguy opened this issue Aug 5, 2021 · 6 comments · Fixed by #601
Closed

(tm_a_mmrm) Name of the column could be improved #11

cicdguy opened this issue Aug 5, 2021 · 6 comments · Fixed by #601

Comments

@cicdguy
Copy link
Contributor

cicdguy commented Aug 5, 2021

all obs could be All observations unless this is a regulatory thing...

Provenance:

Creator: kpagacz
@cicdguy cicdguy added the core label Aug 5, 2021
@cicdguy
Copy link
Contributor Author

cicdguy commented Aug 5, 2021

THe all obs name does not appear to be assigned in the TMC module. It may come from build_table of rtables.

Provenance:

Creator: junlue

@cicdguy
Copy link
Contributor Author

cicdguy commented Aug 5, 2021

THe all obs name does not appear to be assigned in the TMC module. It may come from build_table of rtables.

@junlue yeah you are right. It is a by default name coming from rtables when there is no split_cols_by

Provenance:

Creator: imazubi

@cicdguy
Copy link
Contributor Author

cicdguy commented Aug 5, 2021

Here is workaround for changing "all obs": insightsengineering/rtables#110

Provenance:

Creator: anajens

@cicdguy
Copy link
Contributor Author

cicdguy commented Aug 5, 2021

So it probably should be implemented somewhere in tern, right?

Provenance:

Creator: kpagacz

@yangx61
Copy link

yangx61 commented Jan 12, 2022

The name of the column should really be 'All Patients'. We can simply update MMRMT01 1.2 following the workaround provided above.

df_no_arm <- tidy(mmrm_results_no_arm)
attr(df_no_arm$AVISIT, "label") <- "Visit"

# Define the split function
split_fun <- drop_split_levels

basic_table() %>%
  add_overall_col("All Patients") %>% 
  add_colcounts() %>%
  split_rows_by("AVISIT", split_fun = split_fun, label_pos = "topleft", split_label = obj_label(df_no_arm$AVISIT)) %>%
  summarize_lsmeans(arms = FALSE) %>%
  append_topleft("  Statistics") %>%
  build_table(df_no_arm, alt_counts_df = adsl_sub)

@shajoezhu shajoezhu added the sme label Aug 17, 2022
@danielinteractive
Copy link
Contributor

Yeah nice small improvement, low priority but also low complexity, can update both TLGC entry as well as template function in tm_a_mmrm()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants