Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

few enhancements #254

Merged
merged 12 commits into from
Mar 18, 2024
Merged

few enhancements #254

merged 12 commits into from
Mar 18, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Jan 24, 2024

  • fixed package level Rd file
  • removed unnecessary empty first line in examples as this is actually being rendered
  • removed pkg:: from docs for packages in Depends
  • fixed example of toggle_slider_ui

@pawelru pawelru marked this pull request as ready for review January 29, 2024 09:01
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        359     359  0.00%    175-602
R/tm_g_gh_correlationplot.R                570     570  0.00%    227-905
R/tm_g_gh_density_distribution_plot.R      285     285  0.00%    135-471
R/tm_g_gh_lineplot.R                       576     576  0.00%    159-832
R/tm_g_gh_scatterplot.R                    252     252  0.00%    144-449
R/tm_g_gh_spaghettiplot.R                  304     304  0.00%    192-564
R/toggleable_slider.R                      154     154  0.00%    72-243
R/utils-arbitrary_lines.r                  125     125  0.00%    19-175
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   39      39  0.00%    12-83
R/zzz.R                                      1       1  0.00%    2
TOTAL                                     2935    2935  0.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 0e7302b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@pawelru pawelru added the core label Mar 14, 2024
@kartikeyakirar
resolving conflicts
2e0167a 
Merge branch 'main' into strict_tests

# Conflicts:
#	R/toggleable_slider.R
#	man/toggle_slider_ui.Rd
@kartikeyakirar
removing pkg:: for dplyr and stringr
e6edc01
@kartikeyakirar
Copy link
Contributor

@pawelru, PR looks great. I have removed pkg:: call for dplyr and stringr and removed ::: call as well. please review e6edc01 before merging .

kartikeyakirar
kartikeyakirar approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@kartikeyakirar kartikeyakirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pawelru
Copy link
Contributor Author

pawelru commented Mar 18, 2024

awesome! thanks for pushing this commit - I somehow missed this!
I'm pushing a dummy commit to trigger workflow and marking this for auto-merge

@pawelru pawelru enabled auto-merge (squash) March 18, 2024 13:37
@pawelru pawelru merged commit fe05e76 into main Mar 18, 2024
22 of 23 checks passed
@pawelru pawelru deleted the strict_tests branch March 18, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartikeyakirar kartikeyakirar kartikeyakirar approved these changes

Assignees

@kartikeyakirar kartikeyakirar

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawelru @kartikeyakirar