Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple scda in goshawk and teal.goshawk #222

Closed
gogonzo opened this issue Jun 29, 2023 · 0 comments · Fixed by insightsengineering/goshawk#198, insightsengineering/scda#127, insightsengineering/scda.2022#126 or #223
Closed

Decouple scda in goshawk and teal.goshawk #222

gogonzo opened this issue Jun 29, 2023 · 0 comments · Fixed by insightsengineering/goshawk#198, insightsengineering/scda#127, insightsengineering/scda.2022#126 or #223
Assignees
@m7pr
Labels
core

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Jun 29, 2023 •
edited
Loading

Related to insightsengineering/nestdevs-tasks#1

Summary

After careful observation, it appears that the scda package is not essential for teal. Consequently, it is advantageous for us to separate scda from teal.

Acceptance Criteria

  • Instead of using scda please save scda datasets (only those used in goshawk and teal.goshawk) to data directory in goshawk. Reuse the same datasets in goshawk and teal.goshawk
  • Revise the roxygen examples to use the minimal example data.
  • If applicable, Update the unit tests to utilize the new data.
  • Update affected vignettes.
  • Update DESCRIPTION file to remove scda and related packages.
  • Update staged_dependencies.yml
@gogonzo gogonzo self-assigned this Jun 29, 2023
@gogonzo gogonzo added the core label Jun 29, 2023
@gogonzo gogonzo removed their assignment Jun 29, 2023
@gogonzo gogonzo changed the title Decouple scda Decouple scda in goshawk and teal.goshawk Jun 30, 2023
@gogonzo gogonzo mentioned this issue Jun 30, 2023
Closed
18 tasks
@m7pr m7pr self-assigned this Jul 11, 2023
This was referenced Jul 11, 2023
Merged
Merged
Merged
Merged
m7pr added a commit to insightsengineering/scda.2022 that referenced this issue Jul 12, 2023
@m7pr
Decouple goshawk (#126)
83a6879 
Fixes insightsengineering/teal.goshawk#222

Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
m7pr added a commit to insightsengineering/scda that referenced this issue Jul 12, 2023
@m7pr
Decouple goshawk (#127)
6f9cd66 
Fixes insightsengineering/teal.goshawk#222

Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
m7pr added a commit to insightsengineering/goshawk that referenced this issue Jul 12, 2023
@m7pr @github-actions
222 decouple scda (#198)
6d3dd7b 
Fixes insightsengineering/teal.goshawk#222

Also needed to remove it from scda and scda.2022 packages
insightsengineering/scda#127
insightsengineering/scda.2022#126

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
m7pr added a commit that referenced this issue Jul 12, 2023
@m7pr
222 decouple scda (#223)
ab6bfe9 
Fixes #222

Also needed to remove it from scda and scda.2022 packages
insightsengineering/scda#127
insightsengineering/scda.2022#126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m7pr m7pr

Labels
core
Projects
None yet
Milestone
No milestone
2 participants
@gogonzo @m7pr