Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused internal function check_simple_name #246

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Jan 10, 2024

Pull Request

Fixes #245

Changes description

  • removes function
  • removes tests
  • removes documentation

Copy link
Contributor

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------
R/cdisc_data.R                       1       1  0.00%    37
R/default_cdisc_join_keys.R         11      11  0.00%    17-35
R/deprecated.R                      69      69  0.00%    16-350
R/dummy_function.R                   5       5  0.00%    16-23
R/formatters_var_labels.R           51      51  0.00%    28-154
R/join_key.R                        38       0  100.00%
R/join_keys-c.R                     12       0  100.00%
R/join_keys-extract.R              128       0  100.00%
R/join_keys-names.R                 15       0  100.00%
R/join_keys-parents.R               30       0  100.00%
R/join_keys-print.R                 45       0  100.00%
R/join_keys-utils.R                 73       3  95.89%   33-36
R/join_keys.R                       21       0  100.00%
R/teal_data-class.R                 25       1  96.00%   70
R/teal_data-datanames.R             10       0  100.00%
R/teal_data-get_code.R              15       1  93.33%   55
R/teal_data-show.R                   4       4  0.00%    13-18
R/teal_data.R                       22       9  59.09%   32, 41-47, 50
R/testhat-helpers.R                 26       0  100.00%
R/topological_sort.R                32       0  100.00%
R/utils-get_code_dependency.R      110       1  99.09%   43
R/verify.R                          42      11  73.81%   68, 98-102, 105-109
R/zzz.R                             10      10  0.00%    4-16
TOTAL                              795     177  77.74%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
TOTAL             0       0  -0.39%

Results for commit: b3a2976

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files   13 suites   2s ⏱️
168 tests 166 ✅ 2 💤 0 ❌
233 runs  231 ✅ 2 💤 0 ❌

Results for commit b3a2976.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
check_simple_name 💀 $0.06$ $-0.06$ $-16$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
check_simple_name 💀 $0.07$ $-0.07$ check_simple_name_behaves_as_expected

Results for commit 7015481

♻️ This comment has been updated with latest results.

@kartikeyakirar kartikeyakirar self-assigned this Jan 10, 2024
Copy link
Contributor

@kartikeyakirar kartikeyakirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@chlebowa chlebowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@averissimo averissimo merged commit 2e53aa8 into main Jan 11, 2024
23 checks passed
@averissimo averissimo deleted the 245_remove_check_simple_name branch January 11, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal function check_simple_name() not Utilized in teal.data
3 participants