Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question]: Should we clean the documentation of new_qenv? #150

Closed
m7pr opened this issue Oct 4, 2023 · 3 comments · Fixed by #166
Closed

[Question]: Should we clean the documentation of new_qenv? #150

m7pr opened this issue Oct 4, 2023 · 3 comments · Fixed by #166
Assignees
@chlebowa
Labels
core question Further information is requested

Comments

@m7pr
Copy link
Contributor

m7pr commented Oct 4, 2023 •
edited
Loading

Described in here #146 (review)
@m7pr m7pr added question Further information is requested core labels Oct 4, 2023
@m7pr m7pr mentioned this issue Oct 4, 2023
Merged
@chlebowa
Copy link
Contributor

chlebowa commented Oct 4, 2023

Speaking as the author of the original comment, I believe we should.
I would add within there as well, once #149 is merged.

@chlebowa chlebowa mentioned this issue Oct 5, 2023
Merged
@chlebowa chlebowa mentioned this issue Oct 24, 2023
Merged
@chlebowa chlebowa mentioned this issue Nov 16, 2023
Merged
@m7pr
Copy link
Contributor Author

m7pr commented Nov 21, 2023

@chlebowa should I rename to qenv instead of new_qenv. Is this issue stil valid?

@chlebowa
Copy link
Contributor

@chlebowa should I rename to qenv instead of new_qenv. Is this issue stil valid?

No!

chlebowa added a commit that referenced this issue Dec 4, 2023
@chlebowa @github-actions
@pawelru @gogonzo
145 create qenvs empty (#156)
9f17086 
Closes #145 

I suggest we take this opportunity to also do #150

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
Co-authored-by: go_gonzo <dawid.kaledkowski@gmail.com>
chlebowa added a commit that referenced this issue Dec 5, 2023
@chlebowa @github-actions
150 collate documentation (#166)
e9619d3 
Closes #150 

Collated documentation for `qenv`, `eval_code`, `within`, and `get_code`
into one page (composed of multiple files).

Cleaned up usage sections of all help pages.

Some stylistic updates.

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chlebowa chlebowa

Labels
core question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

150 collate documentation insightsengineering/teal.code
2 participants
@chlebowa @m7pr