Skip to content

Commit

Permalink
Adds min package version (#123)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
* #104

### 🔴 Checklist for PR Reviewer

- [x] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [x] Package versions are the same or higher than `main`
- [x] Package list is the same
  - Only exception is `rmarkdown` (on `Suggests`)
- [x] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [x] Added entry to `NEWS.md`
- [x] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [x] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action

---------

Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Co-authored-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com>
  • Loading branch information
averissimo and chlebowa committed Sep 5, 2023
1 parent 3354138 commit 12c395f
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 10 deletions.
23 changes: 23 additions & 0 deletions .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
name: Scheduled 🕰️

on:
schedule:
- cron: '45 3 * * 0'
workflow_dispatch:

jobs:
dependency-test:
strategy:
fail-fast: false
matrix:
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }}
GCHAT_WEBHOOK: ${{ secrets.GCHAT_WEBHOOK }}
with:
strategy: ${{ matrix.test-strategy }}
additional-env-vars: |
PKG_SYSREQS_DRY_RUN=true
31 changes: 21 additions & 10 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,34 @@ License: Apache License 2.0 | file LICENSE
Depends:
R (>= 4.0)
Imports:
checkmate,
checkmate (>= 2.1.0),
lifecycle (>= 0.2.0),
grDevices,
lifecycle,
methods,
rlang,
shiny,
styler
rlang (>= 1.1.0),
shiny (>= 1.6.0),
styler (>= 1.2.0)
Suggests:
cli,
knitr,
magrittr,
rmarkdown,
testthat (>= 2.0)
cli (>= 3.4.0),
knitr (>= 1.42),
magrittr (>= 1.5),
rmarkdown (>= 2.19),
testthat (>= 3.1.5)
VignetteBuilder:
knitr
RdMacros:
lifecycle
Config/Needs/verdepcheck:
mllg/checkmate,
r-lib/lifecycle,
r-lib/rlang,
rstudio/shiny,
r-lib/styler,
r-lib/cli,
yihui/knitr,
tidyverse/magrittr,
rstudio/rmarkdown,
r-lib/testthat
Config/Needs/website: insightsengineering/nesttemplate
Encoding: UTF-8
Language: en-US
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

### Miscellaneous
* Fix NEWS
* Specified minimal version of package dependencies.

# teal.code 0.4.0

Expand Down

0 comments on commit 12c395f

Please sign in to comment.