This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Decouple scda #123
Merged
Decouple scda #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gogonzo
commented
Jun 29, 2023
•
gogonzo
commented
- teal Decouple scda teal#858
- teal.widgets
- osprey Decouple scda osprey#121
- teal.osprey Decouple scda teal.osprey#214
- teal.transform Decouple scda teal.transform#139
This was referenced Jun 30, 2023
| @@ -27,12 +24,6 @@ downstream_repos: | |||
| insightsengineering/teal.modules.general: | |||
There was a problem hiding this comment.
Downward dependency
As of this insightsengineering/teal.transform#133 scda is going to be decoupled from teal.trasform once merged . this should be removed
| @@ -15,24 +15,12 @@ downstream_repos: | |||
| insightsengineering/goshawk: | |||
| repo: insightsengineering/goshawk | |||
| host: https://github.com | |||
| insightsengineering/teal: | |||
| repo: insightsengineering/teal | |||
| host: https://github.com | |||
| insightsengineering/teal.data: | |||
| repo: insightsengineering/teal.data | |||
| host: https://github.com | |||
There was a problem hiding this comment.
There is a task assigned for insightsengineering/teal.data#145, which involves removing scda from teal.data. I'm a little uncertain about whether this removal should be done now or at a later time. Should pull request be kept it on hold until the task is merged?
There was a problem hiding this comment.
We can merge what is ready now and open decouple_scda@main again for other PRs. It's not a problem.
gogonzo
added a commit
to insightsengineering/osprey
that referenced
this pull request
Jul 6, 2023
closes insightsengineering/teal.osprey#213 see also: - insightsengineering/scda#125 - insightsengineering/scda.2022#123 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
gogonzo
added a commit
to insightsengineering/teal.osprey
that referenced
this pull request
Jul 6, 2023
closes #213 #204 see also: - insightsengineering/scda#125 - insightsengineering/scda.2022#123
gogonzo
added a commit
to insightsengineering/teal
that referenced
this pull request
Jul 6, 2023
closes #834 see also: - insightsengineering/scda#125 - insightsengineering/scda.2022#123 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.