Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update, greenci, skip test if dplyr not available #224

Merged
merged 14 commits into from
Sep 3, 2024
Merged

Conversation

shajoezhu
Copy link
Collaborator

close #221

Copy link
Contributor

github-actions bot commented Sep 3, 2024

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------------------------------------------------
R/paginate_listing.R        29       5  82.76%   81-86
R/rlistings_methods.R      117      26  77.78%   18-29, 49, 65, 69, 155-158, 161, 245-251
R/rlistings.R              181      26  85.64%   159-162, 165-168, 176, 209-213, 385-388, 392-395, 424-427
TOTAL                      327      57  82.57%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: e9ccb68

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Unit Tests Summary

  1 files   5 suites   9s ⏱️
 37 tests 29 ✅  8 💤 0 ❌
104 runs  91 ✅ 13 💤 0 ❌

Results for commit e9ccb68.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
paginate_listing 💚 $6.33$ $-1.15$ $-8$ $+4$ $0$ $0$

Results for commit 25fb0eb

♻️ This comment has been updated with latest results.

Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
vignettes/ref_footnotes.Rmd Outdated Show resolved Hide resolved
@shajoezhu shajoezhu enabled auto-merge (squash) September 3, 2024 08:41
shajoezhu and others added 2 commits September 3, 2024 16:42
Co-authored-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Co-authored-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
vignettes/ref_footnotes.Rmd Outdated Show resolved Hide resolved
Co-authored-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
vignettes/ref_footnotes.Rmd Outdated Show resolved Hide resolved
Signed-off-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
Signed-off-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shajoezhu shajoezhu merged commit 9a6919a into main Sep 3, 2024
28 checks passed
@shajoezhu shajoezhu deleted the 221_green_Ci branch September 3, 2024 09:04
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI green for https://github.com/pawelru/ie_status?tab=readme-ov-file
2 participants