Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination vignette #177

Merged
merged 10 commits into from
Oct 24, 2023
Merged

Pagination vignette #177

merged 10 commits into from
Oct 24, 2023

Conversation

edelarua
Copy link
Contributor

Closes #142

@edelarua edelarua added the sme label Oct 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited
Loading

Unit Tests Summary

  1 files    4 suites   8s ⏱️
31 tests 24 ✔️ 7 💤 0 ❌
79 runs  70 ✔️ 9 💤 0 ❌

Results for commit fcde9a3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              167      26  84.43%   158-161, 164-167, 206-210, 374-377, 381-384, 413, 417-420
TOTAL                      315      41  86.98%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: fcde9a3

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Melkiades
Melkiades reviewed Oct 24, 2023
View reviewed changes
vignettes/Pagination.Rmd Outdated Show resolved Hide resolved
Melkiades
Melkiades reviewed Oct 24, 2023
View reviewed changes
vignettes/Pagination.Rmd Outdated Show resolved Hide resolved
Melkiades
Melkiades reviewed Oct 24, 2023
View reviewed changes
vignettes/Pagination.Rmd Outdated Show resolved Hide resolved
Melkiades
Melkiades reviewed Oct 24, 2023
View reviewed changes
vignettes/Pagination.Rmd Outdated Show resolved Hide resolved
Melkiades
Melkiades approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Just a couple of comments. Thanks Emily ;)

ayogasekaram
ayogasekaram reviewed Oct 24, 2023
View reviewed changes
vignettes/Pagination.Rmd Outdated Show resolved Hide resolved
vignettes/Pagination.Rmd Outdated Show resolved Hide resolved
vignettes/Pagination.Rmd Outdated Show resolved Hide resolved
vignettes/Pagination.Rmd Outdated Show resolved Hide resolved
vignettes/Pagination.Rmd Outdated Show resolved Hide resolved
vignettes/Pagination.Rmd Outdated Show resolved Hide resolved
vignettes/Pagination.Rmd Outdated Show resolved Hide resolved
vignettes/Pagination.Rmd Outdated Show resolved Hide resolved
ayogasekaram
ayogasekaram approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ayogasekaram ayogasekaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content looks good @edelarua. Just made a few grammar edits.

vignettes/pagination.Rmd Outdated Show resolved Hide resolved
vignettes/pagination.Rmd Outdated Show resolved Hide resolved
vignettes/pagination.Rmd Outdated Show resolved Hide resolved
vignettes/pagination.Rmd Outdated Show resolved Hide resolved
vignettes/pagination.Rmd Outdated Show resolved Hide resolved
vignettes/pagination.Rmd Outdated Show resolved Hide resolved
vignettes/pagination.Rmd Outdated Show resolved Hide resolved
vignettes/pagination.Rmd Outdated Show resolved Hide resolved
@edelarua edelarua merged commit 47e4733 into main Oct 24, 2023
23 checks passed
@edelarua edelarua deleted the 142_pagination_vignette@main branch October 24, 2023 20:23
@edelarua edelarua mentioned this pull request Oct 25, 2023
Merged
edelarua added a commit that referenced this pull request Oct 26, 2023
@edelarua
Column formatting vignette (#181)
98e84ac 
Closes #177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Melkiades Melkiades Melkiades approved these changes

@ayogasekaram ayogasekaram ayogasekaram approved these changes

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding vignette example of work around of "pagination by param“
3 participants
@edelarua @Melkiades @ayogasekaram