Skip to content

Commit

Permalink
Adds min package version (#139)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
* #130 

### 🔴 Checklist for PR Reviewer

- [ ] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [ ] Package versions are the same or higher than `main`
- [ ] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [ ] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [ ] Added entry to `NEWS.md`
- [ ] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [ ] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* [x] `formatters` release of the next version and update DESCRIPTION
accordingly
  * `fmt_config` is required and only available at `formatters@main` atm
* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action

---------

Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
  • Loading branch information
averissimo and m7pr committed Sep 15, 2023
1 parent eb8a128 commit 8d2560f
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min", "release", "max"]
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
Expand Down
26 changes: 17 additions & 9 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,30 @@ Description: Listings are often part of the submission of clinical trial
License: Apache License 2.0
URL: https://github.com/insightsengineering/rlistings
BugReports: https://github.com/insightsengineering/rlistings/issues
Depends:
Depends:
formatters (>= 0.5.2),
methods,
tibble
tibble (>= 2.0.0)
Imports:
checkmate,
checkmate (>= 2.1.0),
grDevices,
grid,
stats,
utils
Suggests:
dplyr,
knitr (>= 1.34),
lifecycle,
testthat (>= 3.0)
VignetteBuilder:
Suggests:
dplyr (>= 1.0.0),
knitr (>= 1.42),
lifecycle (>= 0.2.0),
testthat (>= 3.0.4)
Config/Needs/verdepcheck:
insightsengineering/formatters,
tidyverse/tibble,
mllg/checkmate,
tidyverse/dplyr,
yihui/knitr,
r-lib/lifecycle,
r-lib/testthat
VignetteBuilder:
knitr
Config/Needs/website: insightsengineering/nesttemplate
Config/testthat/edition: 3
Expand Down
3 changes: 2 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
## rlistings 0.2.4
* Added `num_rep_cols` method for listings. Resolves error with key column repetition during pagination .
* Fixed a bug when exporting a degenerative list, which is a data frame of a single row and a single column.

* Specified minimal version of package dependencies.

## rlistings 0.2.3
* Added new arguments `default_formatting` and `col_formatting` to `as_listing` to specify column format configurations.
* Added new argument `unique_rows` to `as_listing` to remove duplicate rows from listing.
Expand Down

0 comments on commit 8d2560f

Please sign in to comment.