222 decouple scda #198
Merged
222 decouple scda #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryDiff against mainResults for commit: 5eb4bc0 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
…ngineering/goshawk into 222_decouple_scda@main
gogonzo
reviewed
Jul 11, 2023
Comment on lines
+1
to
+25
| #' Random lab analysis | ||
| #' | ||
| #' @description Random lab analysis | ||
| #' @docType data | ||
| #' | ||
| #' @usage rADLB | ||
| #' | ||
| #' @keywords datasets internal | ||
| #' | ||
| #' @source internal | ||
| #' @name rADLB | ||
| "rADLB" | ||
|
|
||
| #' Random patient listing | ||
| #' | ||
| #' @description Random patient listing | ||
| #' @docType data | ||
| #' | ||
| #' @keywords datasets internal | ||
| #' | ||
| #' @usage rADSL | ||
| #' | ||
| #' @source internal | ||
| #' @name rADSL | ||
| "rADSL" |
gogonzo
approved these changes
Jul 11, 2023
Merged
m7pr
added a commit
to insightsengineering/teal.transform
that referenced
this pull request
Jul 12, 2023
A follow-up after #139 that closed #133 After I had a chance to do a scda decoupling for goshawk insightsengineering/goshawk#198 and had a chance to review scda decoupling for teal.modules.general insightsengineering/teal.modules.general#534 I realized some changes need to be applied in PRs that were already merged in other packages. Main changes: - I prepend dataset names with package names as now we are having the same data in multiple packages (`teal.transform::rADAE` and `teal.modules.general::rADAE` for example) - added a `data-raw/data.R` file to show how the `data/` folder was created - extended `.RBuildignore` file to omit `data-raw/data.R` while building the package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes insightsengineering/teal.goshawk#222
Also needed to remove it from scda and scda.2022 packages insightsengineering/scda#127 insightsengineering/scda.2022#126