Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prototype #754

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

add prototype #754

wants to merge 7 commits into from

Conversation

BFalquet
Copy link
Contributor

@BFalquet BFalquet commented Jun 4, 2024

add ael04 listing template

thank you for the review.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------------------------------------------------------------------------------------
R/ael01_nollt.R                  6       0  100.00%
R/ael02.R                       27       0  100.00%
R/ael03.R                       34       0  100.00%
R/ael04.R                       22       0  100.00%
R/aet01_aesi.R                 148       1  99.32%   214
R/aet01.R                      104       5  95.19%   77-80, 183
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   116
R/aet10.R                       42       0  100.00%
R/assertions.R                  93       7  92.47%   11-16, 123
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      149       0  100.00%
R/cml02a_gl.R                    8       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   130
R/dmt01.R                       38       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   51, 55-59
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   157
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       59       1  98.31%   51
R/fstg01.R                      43       0  100.00%
R/fstg02.R                      48       0  100.00%
R/kmg01.R                       35       6  82.86%   35-40
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       5  92.42%   124-129
R/lbt06.R                       70       0  100.00%
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       55       0  100.00%
R/mng01.R                       95      12  87.37%   86, 90-94, 126-130, 133, 175
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/report_null.R                 24       0  100.00%
R/rmpt01.R                      59      11  81.36%   88-97, 132
R/rmpt06.R                     134       3  97.76%   209-212
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              319      23  92.79%   51, 68, 119, 243, 264, 372-379, 446, 461-463, 465, 534-540, 550, 571
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     120       3  97.50%   202-205
R/utils.R                      178      30  83.15%   123, 139, 158-160, 232-236, 277-280, 284-287, 314, 318, 330, 332, 344, 361-363, 385-398
R/vst02.R                       45       1  97.78%   109
R/zzz.R                          1       1  0.00%    2
TOTAL                         3401     121  96.44%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/ael01_nollt.R                -15      -1  +4.76%
R/ael02.R                      +27       0  +100.00%
R/ael03.R                      +34       0  +100.00%
R/ael04.R                      +22       0  +100.00%
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                      +10      +4  -3.74%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                  -6      +1  -1.47%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +13      -4  +2.94%
R/cml02a_gl.R                   +8       0  +100.00%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +9       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                       -1       0  -0.03%
R/fstg01.R                      -7       0  +100.00%
R/fstg02.R                      -7       0  +100.00%
R/kmg01.R                       +6      +6  -17.14%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1       0  -0.11%
R/lbt06.R                       -2      -3  +4.17%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -16       0  +100.00%
R/mng01.R                       -1     +11  -11.59%
R/pdt02.R                       -1       0  +100.00%
R/report_null.R                +24       0  +100.00%
R/rmpt01.R                      -6       0  -1.72%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +19      +4  -0.88%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +3       0  +0.06%
R/utils.R                      +94     +30  -16.85%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +330     +46  -1.12%

Results for commit: 544d37c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Unit Tests Summary

  1 files   58 suites   3m 29s ⏱️
283 tests 282 ✅ 1 💤 0 ❌
659 runs  650 ✅ 9 💤 0 ❌

Results for commit 544d37c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ael04 👶 $+1.04$ $+6$ $0$ $0$ $0$
aet04 💔 $4.47$ $+7.29$ $+8$ $-2$ $0$ $0$
chevron_tlg-methods 💔 $5.65$ $+2.67$ $+6$ $-10$ $0$ $0$
coxt01 💔 $0.60$ $+1.41$ $+6$ $-1$ $0$ $0$
coxt02 💔 $0.81$ $+1.63$ $+6$ $-1$ $0$ $0$
rmpt03 💔 $1.22$ $+1.00$ $+4$ $-3$ $0$ $0$
rspt01 💔 $4.51$ $+3.60$ $+12$ $-7$ $0$ $0$
ttet01 💔 $2.85$ $+2.55$ $+6$ $-4$ $0$ $0$
utils 💔 $0.16$ $+2.39$ $+61$ $-1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ael04 👶 $+0.23$ ael04_can_handle_all_missing_values
ael04 👶 $+0.40$ ael04_functions_work_as_expected
ael04 👶 $+0.41$ ael04_works_with_adsl_dataset
aet04 💔 $0.94$ $+1.18$ aet04_can_handle_NA_values
aet04 💔 $3.53$ $+6.11$ aet04_can_handle_some_NA_values
chevron_tlg-methods 💔 $1.12$ $+1.14$ script_funs_generates_a_valid_script
coxt01 💔 $0.56$ $+1.43$ coxt01_can_handle_some_NA_values
coxt02 💔 $0.78$ $+1.64$ coxt02_can_handle_some_NA_values
utils 👶 $+0.01$ convert_to_month_warning_messages_as_expected
utils 👶 $+0.02$ convert_to_month_work_as_expected
utils 👶 $+0.02$ do_call_errors_as_expected
utils 👶 $+0.01$ do_call_work_as_expected
utils 👶 $+0.01$ droplevels.character_works_as_expected
utils 👶 $+0.04$ execute_with_args_works_as_expected
utils 👶 $+0.01$ expand_list_works
utils 👶 $+0.01$ format_date_works_as_expected_for_Date
utils 👶 $+0.01$ format_date_works_as_expected_for_POSIXct
utils 👶 $+0.01$ get_section_div_works
utils 👶 $+0.96$ gg_list_is_deprecated
utils 👶 $+0.02$ gg_theme_chevron_works_as_expected
utils 👶 $+0.98$ grob_list_is_deprecated
utils 👶 $+0.01$ lvls.character_works_as_expected
utils 👶 $+0.01$ lvls.default_works_as_expected
utils 👶 $+0.01$ lvls.factor_works_as_expected
utils 👶 $+0.01$ modify_character_works
utils 👶 $+0.01$ modify_default_args_works_as_expected
utils 👶 $+0.01$ quote_str_works_as_expected
utils 👶 $+0.02$ set_section_div_works

Results for commit 075441f

♻️ This comment has been updated with latest results.

R/ael04.R Outdated Show resolved Hide resolved
@BFalquet BFalquet requested a review from clarkliming July 3, 2024 11:14
Signed-off-by: b_falquet <64274616+BFalquet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants