-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ard_regression_basic(). #62
Conversation
Code Coverage Summary
Diff against main
Results for commit: 9d1944f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 16 suites 2s ⏱️ Results for commit 9d1944f. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 6ff56cd ♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 99.81% 99.63% -0.18%
==========================================
Files 10 11 +1
Lines 534 547 +13
==========================================
+ Hits 533 545 +12
- Misses 1 2 +1 ☔ View full report in Codecov by Sentry. |
thanks @rparmm ! taking a first look here. can you fill out the top portion of the review checklist and update so the spell check passes as well? let me know if you have any Qs! |
I have been trying to fix that spell check. It seems like it is coming from the word |
@rparmm I think it was coming from the help file title? i am not 100% sure, but I updated some text and it went away! i'll finish up the review later this week. Thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @rparmm !! i moved the function to its own script. looks great!
What changes are proposed in this pull request?
ard_regression_basic()
Adds
ard_regression_basic()
, a wrapper function around theard_regression
S3 to provide basic statistics in ARD format for regression models.closes #46
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).