Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monthly downloads badge to README #317

Closed
ddsjoberg opened this issue Sep 13, 2024 · 2 comments · Fixed by #318
Closed

Add monthly downloads badge to README #317

ddsjoberg opened this issue Sep 13, 2024 · 2 comments · Fixed by #318
Labels
good first issue Good for newcomers sme
Milestone
v0.3.0

Comments

@ddsjoberg
Copy link
Collaborator

No description provided.

@ddsjoberg ddsjoberg added the good first issue Good for newcomers label Sep 13, 2024
@Rohans-7
Copy link

Which downloads badge do we have to add, Can you explain.

@ddsjoberg ddsjoberg mentioned this issue Sep 13, 2024
Merged
12 tasks
@ddsjoberg ddsjoberg added this to the v0.3.0 milestone Sep 13, 2024
ddsjoberg added a commit that referenced this issue Sep 13, 2024
@ddsjoberg
Adding download badge to README (#318)
7329f76 
**Reference GitHub issue associated with pull request.** _e.g., 'closes
#<issue number>'_
closes #317 


--------------------------------------------------------------------------------

Pre-review Checklist (if item does not apply, mark is as complete)
- [ ] **All** GitHub Action workflows pass with a ✅
- [ ] PR branch has pulled the most recent updates from master branch:
`usethis::pr_merge_main()`
- [ ] If a bug was fixed, a unit test was added.
- [ ] Code coverage is suitable for any new functions/features
(generally, 100% coverage for new code): `devtools::test_coverage()`
- [ ] Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

- [ ] If a bug was fixed, a unit test was added.
- [ ] Run `pkgdown::build_site()`. Check the R console for errors, and
review the rendered website.
- [ ] Code coverage is suitable for any new functions/features:
`devtools::test_coverage()`

When the branch is ready to be merged:
- [ ] Update `NEWS.md` with the changes from this pull request under the
heading "`# cards (development version)`". If there is an issue
associated with the pull request, reference it in parentheses at the end
update (see `NEWS.md` for examples).
- [ ] **All** GitHub Action workflows pass with a ✅
- [ ] Approve Pull Request
- [ ] Merge the PR. Please use "Squash and merge" or "Rebase and merge".
@ddsjoberg
Copy link
Collaborator Author

@Rohans-7 we added this CRAN downloads badge to the README
image

@shajoezhu shajoezhu added the sme label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers sme
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Adding download badge to README insightsengineering/cards
3 participants
@shajoezhu @ddsjoberg @Rohans-7