-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bind_ard(.distinct)
argument
#307
Conversation
Hi @bzkrouse @Melkiades @ayogasekaram @edelarua ! I requested multiple reviewers, but we only need one. When you have the time to reivew, can you remove the other reviewers before you begin? |
Code Coverage Summary
Diff against main
Results for commit: bac9972 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 112 suites 28s ⏱️ Results for commit bac9972. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit 39d8439 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the messaging! Very clear to me. Thanks Daniel
Big thanks @Melkiades ! |
What changes are proposed in this pull request?
bind_ard(.distinct)
argument, which can remove non-distinct rows from the ARD across grouping variables, primary variables, context, statistic name and value. (Updatebind_ard()
to remove duplicate statistics #286)Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #286
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).