Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bind_ard(.distinct) argument #307

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Added bind_ard(.distinct) argument #307

merged 5 commits into from
Aug 30, 2024

Conversation

ddsjoberg
Copy link
Collaborator

What changes are proposed in this pull request?

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #286


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@ddsjoberg
Copy link
Collaborator Author

Hi @bzkrouse @Melkiades @ayogasekaram @edelarua ! I requested multiple reviewers, but we only need one. When you have the time to reivew, can you remove the other reviewers before you begin?

Copy link
Contributor

github-actions bot commented Aug 29, 2024

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -----------------------------------
R/add_calculated_row.R            46       0  100.00%
R/apply_fmt_fn.R                  98      24  75.51%   45-52, 118-125, 207-214
R/ard_attributes.R                35       1  97.14%   56
R/ard_categorical.R              348      21  93.97%   233, 390-394, 401-402, 563-578, 612
R/ard_complex.R                   36       1  97.22%   83
R/ard_continuous.R               176       4  97.73%   118, 200-201, 299
R/ard_dichotomous.R               80       7  91.25%   62, 150-155
R/ard_hierarchical.R              83       0  100.00%
R/ard_missing.R                   58       1  98.28%   50
R/ard_stack.R                     84       7  91.67%   107, 186-191
R/ard_total_n.R                   10       0  100.00%
R/as_card.R                        5       0  100.00%
R/as_nested_list.R                41       0  100.00%
R/bind_ard.R                      47      18  61.70%   74-85, 87-93
R/check_ard_structure.R           39       6  84.62%   31, 55-59
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            16       1  93.75%   75
R/nest_for_ard.R                  71       1  98.59%   60
R/print_ard_conditions.R          75       1  98.67%   175
R/print.R                         72       0  100.00%
R/process_selectors.R            126       1  99.21%   337
R/replace_null_statistic.R        11       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     19       0  100.00%
R/shift_ard_columns.R             77      13  83.12%   61, 69, 144-147, 150-156
R/shuffle_ard.R                  102       0  100.00%
R/summary_functions.R             25       1  96.00%   59
R/tidy_ard_order.R                25       0  100.00%
R/tidy_as_ard.R                   39      11  71.79%   88-98
R/utils.R                         24       0  100.00%
TOTAL                           1905     119  93.75%

Diff against main

Filename        Stmts    Miss  Cover
------------  -------  ------  -------
R/bind_ard.R      +24     +15  -25.25%
TOTAL             +24     +15  -0.72%

Results for commit: bac9972

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Unit Tests Summary

  1 files  112 suites   28s ⏱️
109 tests  68 ✅ 41 💤 0 ❌
236 runs  179 ✅ 57 💤 0 ❌

Results for commit bac9972.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
bind_ard 👶 $+0.00$ bind_ard_.distinct_

Results for commit 39d8439

♻️ This comment has been updated with latest results.

R/bind_ard.R Outdated Show resolved Hide resolved
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the messaging! Very clear to me. Thanks Daniel

@ddsjoberg
Copy link
Collaborator Author

Big thanks @Melkiades !

@ddsjoberg ddsjoberg merged commit 1bde0be into main Aug 30, 2024
35 checks passed
@ddsjoberg ddsjoberg deleted the 286-bind_ard-distinct branch August 30, 2024 17:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bind_ard() to remove duplicate statistics
2 participants