Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using ImportQualifiedPost #79

Merged
merged 11 commits into from
Nov 4, 2021
Merged

Switch to using ImportQualifiedPost #79

merged 11 commits into from
Nov 4, 2021

Conversation

sjoerdvisscher
Copy link
Contributor

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@michaelpj
Copy link
Contributor

You'll also need to bump the stylish-haskell version to 0.13.0.0, I think.

silky
silky approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@silky silky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is happy I'm happy! Thanks for doing this :)

@sjoerdvisscher
Copy link
Contributor Author

Yeah, but the files don't actually use ImportQualifiedPost formatting yet.

@silky
Copy link
Contributor

silky commented Nov 3, 2021

@sjoerdvisscher a minor issue I failed to notice ... 😂

@sjoerdvisscher
Copy link
Contributor Author

@silky Same here, otherwise I hadn't tagged you to review it yet 😆

@sjoerdvisscher sjoerdvisscher force-pushed the sv/ImportQualifiedPost branch 5 times, most recently from 6fc7691 to 404298f Compare November 4, 2021 11:48
@sjoerdvisscher sjoerdvisscher merged commit d637b19 into main Nov 4, 2021
@sjoerdvisscher sjoerdvisscher deleted the sv/ImportQualifiedPost branch November 4, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silky silky silky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjoerdvisscher @michaelpj @silky