SCP-3069: Hello world demo app integrating Nami wallet with the PAB #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koslambrou
force-pushed
the
scp-3069-pab-nami-demo
branch
from
8f80f3c
to
be69a8a
Compare
koslambrou
force-pushed
the
scp-3069-pab-nami-demo
branch
2 times, most recently
from
79e6f2f
to
aa090e2
Compare
catch-21
reviewed
Dec 15, 2021
|
Would love to see a more involved transaction, with validator scripts, datums etc. Is it also planned? |
|
@gege251 Yes, that will be the next step. This PR is more about a "hello world" type example for setting everything up. |
catch-21
approved these changes
Dec 15, 2021
koslambrou
force-pushed
the
scp-3069-pab-nami-demo
branch
2 times, most recently
from
0973bb8
to
0bae4d4
Compare
Co-authored-by: Jamie Bertram <jamie.bertram@tweag.io>
koslambrou
force-pushed
the
scp-3069-pab-nami-demo
branch
from
0bae4d4
to
cdf16fe
Compare
hrajchert
reviewed
Dec 28, 2021
Comment on lines
+11
to
+19
| exports.getWalletIdImpl = () => { | ||
| return Promise.all([window.cardano.getUsedAddresses(), window.cardano.getUnusedAddresses()]) | ||
| .then(([walletUsedAddresses, walletUnusedAddresses]) => { | ||
| const addresses = walletUnusedAddresses.concat(walletUsedAddresses) | ||
| return require('blake2b')(20) | ||
| .update(Buffer.from(addresses.map(a => a.to_bech32).join(''))) | ||
| .digest('hex') | ||
| }) | ||
| } |
There was a problem hiding this comment.
@koslambrou does this generate a WalletId compatible with the WBE?
There was a problem hiding this comment.
yes this uses the same hash algorithm as the one used in WBE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple demo app which demonstrates how to integrate the PAB with a light wallet (Nami in this case, but should work with other light wallets which respect the CIP-0030 standard.).
Pre-submit checklist: