Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ChainPoint conversion from pallas Point #2037

Open
1 task
jpraynaud opened this issue Oct 22, 2024 · 0 comments
Open
1 task

Refactor ChainPoint conversion from pallas Point #2037

jpraynaud opened this issue Oct 22, 2024 · 0 comments
Assignees
@Alenar
Labels
refactoring 🛠️ Code refactoring and enhancements

Comments

@jpraynaud
Copy link
Member

Why

The conversion from pallas Point representation to ChainPoint is problematic as it introduces a BlockNumber with value 0.
This means that the conversionis not safe and should be done to another type which does not hold a BlockNumber.

What

Refactor the conversion from Point to RawCardanoPoint instead of ChainPoint

How

  • Refactor the conversion from Point to RawCardanoPoint instead of ChainPoint
@jpraynaud jpraynaud added the refactoring 🛠️ Code refactoring and enhancements label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alenar Alenar

Labels
refactoring 🛠️ Code refactoring and enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alenar @jpraynaud