Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in repository #1862

Closed
2 tasks done
jpraynaud opened this issue Jul 29, 2024 · 0 comments · Fixed by #1865
Closed
2 tasks done

Typos in repository #1862

jpraynaud opened this issue Jul 29, 2024 · 0 comments · Fixed by #1865
Assignees
Labels
devX 🌞 Developer experience

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Jul 29, 2024

Why

We have noticed some typos in the repository and we want to fix them.

What

Fix the typos in the repository (comments and variable names)

How

  • Fix the typos listed here:
demo/protocol-demo/src/demonstrator.rs
- line 165 "agreggate" -> "aggregate"

mithril-aggregator/src/artifact_builder/cardano_immutable_files_full.rs
- line 303 "remove_snapshot_archive_after_upload_even_if_an_error_occured" -> "remove_snapshot_archive_after_upload_even_if_an_error_occurred"

mithril-aggregator/src/database/record/certificate.rs
- line 5 "HexEncodedAgregateVerificationKey" -> "HexEncodedAggregateVerificationKey"
- line 39 "" -> ""

mithril-aggregator/src/database/record/signed_entity.rs
- line 134 "mithtril_stake_distribution_message" -> "mithril_stake_distribution_message"
- line 143 "" -> ""

mithril-aggregator/src/database/repository/open_message_repository.rs
- line 24 "Instanciate" -> "Instantiate"

mithril-aggregator/src/dependency_injection/error.rs
- line 11 "occure" -> "occur"

mithril-aggregator/src/event_store/event.rs
- line 33 "Instanciate" -> "Instantiate"
- line 150 "" -> ""

mithril-aggregator/src/event_store/runner.rs
- line 17 "Instanciate" -> "Instantiate"

mithril-aggregator/src/event_store/transmitter_service.rs
- line 22 "Instanciate" -> "Instantiate"
- line 65 "occured" -> "occurred"

mithril-aggregator/src/http_server/routes/middlewares.rs
- line 122 "with_prover_transations_hash_validator" -> "with_prover_transactions_hash_validator"

mithril-aggregator/src/http_server/routes/proof_routes.rs
- line 46 "with_prover_transations_hash_validator" -> "with_prover_transactions_hash_validator"

mithril-aggregator/src/runtime/error.rs
- line 10 "occured" -> "occurred"
- line 31 "" -> ""

mithril-aggregator/src/services/message.rs
- line 221 "certficate_message" -> "certificate_message"
- line 225 "" -> ""

mithril-aggregator/src/services/stake_distribution
- line 43 "occured" -> "occurred"

mithril-aggregator/src/store/protocol_parameters_store.rs
- line 66 "protocol_paremeters" -> "protocol_parameters"
- line 67 "" -> ""
- line 71 "" -> ""
- line 72 "" -> ""
- line 134 "test_handle_discrepandies_at_startup_should_complete_at_least_two_epochs" -> "test_handle_discrepancies_at_startup_should_complete_at_least_two_epochs"

mithril-aggregator/src/tools/remote_file_uploader.rs
- line 65 "gcloud" -> "cloud" ?

mithril-aggregator/tests/test_extensions/expected_certificate.rs
- line 2 "HexEncodedAgregateVerificationKey" -> "HexEncodedAggregateVerificationKey"
- line 13 "" -> ""
- line 21 "" -> ""
- line 35 "" -> ""

mithril-aggregator/tests/test_extensions/runtime_tester.rs
- line 377 "everytime" -> "every time"

mithril-aggregator/tests/test_extensions/utilities.rs
- line 11 "artefacts" -> "artifacts"
- line 13 "debuging" -> "debugging"

mithril-aggregator/tests/certificate_chain.rs
- line 44 "Boostrap" -> "Bootstrap"

mithril-aggregator/tests/create_certificate.rs
- line 52 "Boostrap" -> "Bootstrap"

mithril-aggregator/tests/era_checker.rs
- line 64 "Boostrap" -> "Bootstrap"

mithril-aggregator/tests/open_message_expiration.rs
- line 41 "Boostrap" -> "Bootstrap"

mithril-aggregator/tests/open_message_newer_exists.rs
- line 39 "Boostrap" -> "Bootstrap"

mithril-aggregator/tests/prove_transactions.rs
- line 58 "Boostrap" -> "Bootstrap"





mithril-client/src/aggregator_client.rs
- line 681 "test_client_can_fallback_to_a_second_version_when_412_api_version_mistmatch" -> "test_client_can_fallback_to_a_second_version_when_412_api_version_mismatch"

mithril-client/src/certificate_client.rs
- line 147 "Certicate" -> "Certificate"





mithril-client-cli/src/utils/preogress_reporter.rs
- line 40 "Instanciate" -> "Instantiate"

skipped mithril-client-wasm

mithril-common/src/chain_observer/pallas_observer.rs
- line 656 "intersepted" -> "intercepted"

mithril-common/src/crypto_helper/cardano/key_certification.rs
- line 157 "decommissionned" -> "decmomissioned"

mithril-common/src/crypto_helper/merkle_map.rs
- line 257 "uwnrap" -> "unwrap"
- line 621 "inexisting" -> "nonexisting"

mithril-common/src/crypto_helper/merkle_tree.rs
- line 330 "uwnrap" -> "unwrap"

mithril-common/src/entities/epoch.rs
- line 206 "triggerred" -> "triggered"

mithril-common/src/entities/protocol_parameters.rs
- line 24 "representatio" -> "representation"

mithril-common/src/entities/signed_entity_type.rs
- line 61 "enty" -> "entity" (?)

mithril-common/src/entities/type_alias.rs
- line 37 "HexEncodedAgregateVerificationKey" -> "HexEncodedAggregateVerificationKey"

mithril-common/src/era/era_reader.rs
- line 49 "Instanciate" -> "Instantiate"

mithril-common/src/messages/certificate_list.rs
- line 239 "succesfully" -> "successfully"

mithril-common/src/messages/epoch_settings.rs
- line 67 "succesfully" -> "successfully"

mithril-common/src/messages/mithril_stake_distribution_list.rs
- line 64 "succesfully" -> "successfully"

mithril-common/src/messages/register_signer.rs
- line 134 "succesfully" -> "successfully"
- line 152 "" -> ""

mithril-common/src/messages/snapshot_download.rs
- line 83 "succefully" -> "successfully"

mithril-common/src/messages/snapshot_list.rs
- line 144 "succesfully" -> "successfully"
- line 169 "" -> ""
- line 195 "" -> ""

mithril-common/src/messages/snapshot.rs
- line 121 "succesfully" -> "successfully"
- line 146 "" -> ""



mithril-signer/src/runtime/error.rs
- line 61 "occured" -> "occurred"
- line 75 "" -> ""

mithril-signer/src/runtime/state_machine.rs
- line 28 "successfuly" -> "successfully"

mithril-signer/src/aggregator_client.rs
- line 355 "Instanciate" -> "Instantiate"

mithril-signer/src/cardano_transactions_preloader_checker.rs
- line 32 "occured" -> "occurred"



mithril-stm/src/eligibility_check.rs
- line 151 "compuation" -> "computation"
  • Also fix the typos added after those that were sent to us:
mithril/internal/mithril-persistence/src/sqlite/condition.rs
line 65 "Instanciate" -> "Instantiate"
line 91 "Instanciate" -> "Instantiate"

mithril/internal/mithril-persistence/src/sqlite/projection.rs
line 47 "Instanciate" -> "Instantiate"

mithril/mithril-aggregator/src/event_store/event.rs
line 33 "Instanciate" -> "Instantiate"
line 150 "Instanciate" -> "Instantiate"

mithril/docs/website/blog/2022-12-05-release-process/index.md
line 40 "artefact" -> "artifact"

mithril/mithril-test-lab/mithril-end-to-end/src/main.rs
line 26 "artefacts" -> "artifacts"

mithril/mithril-aggregator/tests/genesis_to_signing.rs
line 43 "Boostrap" -> "Bootstrap"

mithril/mithril-test-lab/mithril-end-to-end/src/main.rs
line 35 "boostrap" -> "bootstrap"

mithril/mithril-common/src/messages/mithril_stake_distribution.rs
line 96 "succesfully" -> "successfully"

mithril/mithril-common/src/messages/register_signature.rs
line 82 "succesfully" -> "successfully"

mithril/mithril-test-lab/docs/test-lab-design.md
line 25 "succesfully" -> "successfully"
@jpraynaud jpraynaud added the devX 🌞 Developer experience label Jul 29, 2024
@sfauvel sfauvel mentioned this issue Jul 29, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devX 🌞 Developer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants