Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SlotNumber type #1851

Closed
2 tasks done
jpraynaud opened this issue Jul 23, 2024 · 0 comments · Fixed by #1854
Closed
2 tasks done

Refactor SlotNumber type #1851

jpraynaud opened this issue Jul 23, 2024 · 0 comments · Fixed by #1854
Assignees
@sfauvel
Labels
refactoring 🛠️ Code refactoring and enhancements

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Jul 23, 2024 •
edited
Loading

Why

Have a stronger type checking implemented on the SlotNumber type which is currently an alias to u64.

What

Refactor the SlotNumber type with a struct.

How

  • Implement SlotNumber with a struct
  • Implement Deref, DerefMut, Eq, Ord, Display, Debug, Copy, Serialize, Deserialize on SlotNumber
@jpraynaud jpraynaud added the refactoring 🛠️ Code refactoring and enhancements label Jul 23, 2024
@sfauvel sfauvel self-assigned this Jul 23, 2024
@sfauvel sfauvel mentioned this issue Jul 25, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfauvel sfauvel

Labels
refactoring 🛠️ Code refactoring and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace SlotNumber alias with dedicated structure input-output-hk/mithril
2 participants
@sfauvel @jpraynaud