Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non blocking artifact production in aggregator #1792

Closed
6 tasks done
jpraynaud opened this issue Jul 1, 2024 · 0 comments · Fixed by #1828
Closed
6 tasks done

Non blocking artifact production in aggregator #1792

jpraynaud opened this issue Jul 1, 2024 · 0 comments · Fixed by #1828
Assignees
Labels
feature 🚀 New implemented feature

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Jul 1, 2024

Why

We need to avoid blocking the signature of new open messages when the aggregator is computing the artifact for a signed entity type (an operation which can take up to several hours). In particular, this will help have a consistent certification of the Cardano transactions which is occurring at a faster pace.

What

Update the artifact production so that:

  • The signed entity type is locked during the operation
  • The signed entity type is unlocked when the operation terminates (success or failure)
  • The computation of the artifact is done in a background thread

How

  • Update the SignedEntityService create_artifact function:
    • Make the computation in a separate task
    • Return the task instead of unit
    • Lock signed entity type
    • Unlock signed entity type (when success or failure)
  • Adapt the integration tests (if any problem occurs because of the background task)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 New implemented feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants