Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregator/Signer preload transactions when Cardano transactions certification is not activated #1782

Closed
3 tasks done
jpraynaud opened this issue Jun 26, 2024 · 0 comments · Fixed by #1796
Closed
3 tasks done
Assignees
Labels
bug ⚠️ Something isn't working

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Jun 26, 2024

Why

The signer and aggregator node import the Cardano transactions during the pre-loading phase, even if this type of data is not activated on the network. The expected behavior is to have the preloading triggered only when the aggregator has activated the Cardano transaction signed entity type.

What

Trigger the signer preloading of the Cardano transactions only if the aggregator advertises the CardanoTransactions in the signed entity types in its root route, and the aggregator preloading of the Cardano transactions only if the CardanoTransactions signed entity type is activated.

How

  • Create a common trait CardanoTransactionsPreloaderActivationState with a async fn is_activated() -> StdResult<bool> function
  • Use the CardanoTransactionsPreloaderActivationState in the aggregator to check if the preloading can be done before preloading
  • Use the CardanoTransactionsPreloaderActivationState in the signer to check if the preloading can be done before preloading
@jpraynaud jpraynaud added the bug ⚠️ Something isn't working label Jun 26, 2024
@jpraynaud jpraynaud changed the title Signer preloads transactions when Cardano transactions certification is not activated Aggregator/Signer preload transactions when Cardano transactions certification is not activated Jul 2, 2024
@jpraynaud jpraynaud mentioned this issue Jul 9, 2024
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ⚠️ Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants