Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional embedding of Cardano CLI in Docker images #1725

Closed
2 tasks done
jpraynaud opened this issue Jun 3, 2024 · 0 comments
Closed
2 tasks done

Conditional embedding of Cardano CLI in Docker images #1725

jpraynaud opened this issue Jun 3, 2024 · 0 comments
Assignees
@sfauvel
Labels
optimization 🛠️ Optimization and/or small enhancements

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Jun 3, 2024 •
edited
Loading

Why

By default the chain observer used is PallasChainObserver which makes the embedding of the Cardano CLI not necessary.
We want to keep the possibility of embedding it in case the chain observer used is switched to the CardanoCLIObserver but not embed it by default anymore.

What

Implement a conditional embedding of the Cardano cli in the aggregator and signer Docker images.

How

  • Implement a conditional embedding of the Cardano cli in the aggregator Docker image
  • Implement a conditional embedding of the Cardano cli in the signer Docker image
@jpraynaud jpraynaud added the optimization 🛠️ Optimization and/or small enhancements label Jun 3, 2024
@jpraynaud jpraynaud mentioned this issue Jun 27, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfauvel sfauvel

Labels
optimization 🛠️ Optimization and/or small enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sfauvel @jpraynaud